Closed Bug 994524 Opened 11 years ago Closed 11 years ago

[Follow up of bug 989135] Fix ssid buffer may overflow

Categories

(Firefox OS Graveyard :: Wifi, defect)

Product:
Firefox OS Graveyard
Component:
Wifi
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S6 (25apr)
Project Flags:
blocking-b2g 1.3T+
Tracking Flags:
Tracking Status
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: dimi, Assigned: dimi)

Details

Attachments

(1 file)

Bug_994524_v1.patch
5.32 KB, patch
chucklee
: review+
bajaj
: approval-mozilla-b2g30+
Details | Diff | Splinter Review
According to Comment 14 of bug 989135, need a fix for possible overflow case
Change char string operation to nsCString to avoid buffer overflow , writing own string operate function
Attachment #8405158 - Flags: review?(chulee)
Comment on attachment 8405158 [details] [diff] [review] Bug_994524_v1.patch Review of attachment 8405158 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thank you.
Attachment #8405158 - Flags: review?(chulee) → review+
blocking-b2g: --- → 1.3T?
Keywords: checkin-needed
Attachment #8405158 - Flags: approval-mozilla-aurora?
triage: follow up bug of a 1.3T+ bug, 1.3T+
blocking-b2g: 1.3T? → 1.3T+
https://hg.mozilla.org/mozilla-central/rev/5a4d56186164
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
dlee, can you please follow the guidelines at https://wiki.mozilla.org/Release_Management/Uplift_rules#Guidelines_on_approval_comments and fill in the details request on the approval request comment for aurora ?
status-b2g-v1.4: --- → affected
Flags: needinfo?(dlee)
comment for aurora approval request for attachment Bug_994524_v1.patch [Approval Request Comment] Bug caused by : This is regressing bug 989135 User impact if declined : For wifi hotspot mode, if user input too many characters with " or \ in SSID, it may cause net worker thread crash. Then wifi or hot spot will malfunction. Testing completed : Yes. Risk to taking this patch : Low, because changing internal string buffer management from character array to nsCString which avoid the possibility of buffer overflow. String or IDL/UUID changes made by this patch: None.
Flags: needinfo?(dlee)
Attachment #8405158 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Looks like bug 989135 never got nominated for 1.4 uplift?
status-b2g-v2.0: --- → fixed
Flags: needinfo?(dlee)
Target Milestone: 2.0 S1 (9may) → 1.4 S6 (25apr)
waiting bug 989135 to be 1.4 uplift
Flags: needinfo?(dlee)
Comment on attachment 8405158 [details] [diff] [review] Bug_994524_v1.patch This most the boat for v1.4 when it was on Aurora. Switching the approval request over to b2g30 where it now is.
Attachment #8405158 - Flags: approval-mozilla-aurora+ → approval-mozilla-b2g30?
Attachment #8405158 - Flags: approval-mozilla-b2g30? → approval-mozilla-b2g30+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: