994548 - Layer masks are drawn incorrectly when doing partial updates in BasicCompositor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Chris Lord [:cwiiis]]

If a partial update is done, the altered size and offset of the target seem to affect layer masks (they get offset and squished accordingly) - I suspect this may be down to transform code in BasicCompositor.cpp.

Comment 1

[Chris Lord [:cwiiis]]

Attachment: BasicCompositor - fix masks when there's an offset on the render target

Another embarrassingly long time to find something so simple. Still, nice that it's this and not something more heinous :)

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8404673 [details] [diff] [review]
BasicCompositor - fix masks when there's an offset on the render target

Review of attachment 8404673 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/basic/BasicCompositor.cpp
@@ +311,5 @@
>      MOZ_ASSERT(effectMask->mMaskTransform.Is2D(), "How did we end up with a 3D transform here?!");
>      MOZ_ASSERT(!effectMask->mIs3D);
>      maskTransform = effectMask->mMaskTransform.As2D();
>    }
> +  maskTransform.Translate(-offset.x, -offset.y);

Shouldn't this go inside the if() condition scope?

Comment 3

[Chris Lord [:cwiiis]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> ::: gfx/layers/basic/BasicCompositor.cpp
> @@ +311,5 @@
> >      MOZ_ASSERT(effectMask->mMaskTransform.Is2D(), "How did we end up with a 3D transform here?!");
> >      MOZ_ASSERT(!effectMask->mIs3D);
> >      maskTransform = effectMask->mMaskTransform.As2D();
> >    }
> > +  maskTransform.Translate(-offset.x, -offset.y);
> 
> Shouldn't this go inside the if() condition scope?

Corrected and pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/8930603310a7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8930603310a7