994572 - The contact name is not complete when contact is edited (Name behind title)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-04-10-05-03-24.png

Tested
Hamachi 
1.5
Gecko e177929
Gaia 8697ff1

Reproducible 100%

STR
1. Tap contact aplication
2. Tap "+" button
3. Write name of contact and in phone writes '1' (phone number with 1 digit)
4. Write "Done" button
5. Tap in contact created
6. Tap in "edit" button

Actual result:
Name of contact is behind title (See image attached)

Expected result:
Name appears not behind title

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

STR are a bit confusing for me, could your rewrite?

Comment 2

[Loli (:lolimartinezcr)]

Attachment: wrong.png

Comment 3

[Loli (:lolimartinezcr)]

Attachment: right.png

Comment 4

[Loli (:lolimartinezcr)]

(In reply to Francisco Jordano [:arcturus] from comment #1)
> STR are a bit confusing for me, could your rewrite?

Yes, of couse,

1. Create a new contact only con name and phone number (phone number only with 1 digit)
     1.1. Tap contact aplication
     1.2. Tap "+" button
     1.3. Write name of contact and in phone writes '1' (phone number with 1 digit)
     1.4. Write "Done" button
2. Edit contact create
     2.1. Tap in contact created
     2.2. Tap in "edit" button

Actual result:
Name of contact is behind orange title (See image attached: wrong.png) when user edits new contact.

Expected result:
Name appears not behind title (See image  attached: right.png) when user edits new contact.

Comment 5

[Noemí Freire (:noemi)]

Attachment: 2014-04-10-06-44-31.png

Hi,

Just adding that if you edit again that contact and change the phone number and add email address, when editing it again the view has changed as attached. It seems to be a scrolling issue. ni to Arnau to see if the layout change in contact details may cause this effect

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

I cannot reproduce it.
Following the steps mentioned above, I get the expected result.

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Oh I see. I guess the scroll is kept from the last position where you left it.
I'm not sure if that should be considered a bug.
But same think happens in Settings for instance:
-tap a section long enough to have scroll (e.g developer)
-scroll to the bottom
-tap header back arrow
-tap again on the section you entered before

Scroll position is were you left it.

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

So, shall we ask Omega about the desired behaviour? Sincerely, for me the "scrolling memory" is quite annoying not only in the Contacts creation case but also in the Settings app once you have move around quite about amongst the sub-pages/menus :-)

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Damn it, I hardly understand myself! :O I hope you do :)

Comment 10

[Noemí Freire (:noemi)]

(In reply to Germán Toro del Valle from comment #8)
> So, shall we ask Omega about the desired behaviour? Sincerely, for me the
> "scrolling memory" is quite annoying not only in the Contacts creation case
> but also in the Settings app once you have move around quite about amongst
> the sub-pages/menus :-)

sure, let's check UX input here. Omega wdyt?.

Comment 11

[Omega Feng [:Omega] [:馮於懋]]

ni? Contacts app UX owner Carrie.

Comment 12

[Carrie Wang [New account: [e-mail]]]

Hi, 

I don't think "scrolling memory" is necessary in Edit mode. For example, I created a new contact and left the page after phone numbers input, but after a while, I'm getting more connected with this new friend and want to change the contact name to a nickname, it will be really odd to display the edit mode focus on phone numbers when I access the contact edit page. Users won't get the idea and neither appreciate it. Hence, I think we shall always display the top of the page in Contact edit. Thanks!

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Carrie Wang [:carrie] from comment #12)
> Hi, 
> 
> I don't think "scrolling memory" is necessary in Edit mode. For example, I
> created a new contact and left the page after phone numbers input, but after
> a while, I'm getting more connected with this new friend and want to change
> the contact name to a nickname, it will be really odd to display the edit
> mode focus on phone numbers when I access the contact edit page. Users won't
> get the idea and neither appreciate it. Hence, I think we shall always
> display the top of the page in Contact edit. Thanks!

+1

It looks weird to me right now.

Comment 14

[Noemí Freire (:noemi)]

Adding to backlog to be properly prioritized. Thanks!

Comment 15

[Fernando Campo (:fcampo)]

Attachment: Link to PR - https://github.com/mozilla-b2g/gaia/pull/19159

Comment 16

[Jose Manuel Cantera]

Comment on attachment 8420908 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19159

it didn't work for me. Please check your solution

Comment 17

[Fernando Campo (:fcampo)]

Attachment: master VS patched

(In reply to Jose Manuel Cantera from comment #16)
> Comment on attachment 8420908 [details] [review]
> Link to PR - https://github.com/mozilla-b2g/gaia/pull/19159
> 
> it didn't work for me. Please check your solution
I tried again on master (hamachi and unagi), and this is the difference that I see. In your device, is there any change at all, or you just see the same with or without it?

Comment 18

[Jose Manuel Cantera]

With your patch the issue still reproduces. Please get in touch with me offline

Comment 19

[Fernando Campo (:fcampo)]

Comment on attachment 8420908 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19159

Updated PR, took the scroll out of the loop so it affects both addContact and editContact.

Please review, and thanks for the tip offline!

Comment 20

[Jose Manuel Cantera]

Comment on attachment 8420908 [details] [review]
Link to PR - https://github.com/mozilla-b2g/gaia/pull/19159

please address the comment in GH, then run Travis and land once is green

thanks Fernando

Comment 21

[Fernando Campo (:fcampo)]

Finally green Travis, merged on master - b61129780e085636d09406f2a46e922d0f8b9757

Comment 22

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko:785d39a
Gaia:7f258db