Closed Bug 994577 Opened 10 years ago Closed 10 years ago

[flame] audio didn't work in nightly build system.img

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: viralwang, Assigned: viralwang)

References

Details

Attachments

(1 file, 1 obsolete file)

updated PR for bug 994577
50 bytes, text/x-github-pull-request
Details | Review 
after flash complete image in bug 978888, audio didn't work
I can open music app and play, but can't hear anything.
Attached file add audio files to make audio work (obsolete) — 
Hi Michael,

Could you please help review this patch?
Thanks.
Attachment #8404585 - Flags: review?(mwu)
Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Request review again after addressing reviewing comments on PR.
Attachment #8404585 - Flags: review?(mwu)
Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Hi Michael,

Few questions need your suggestions on PR.
Could you please help on it?
Thanks!
Attachment #8404585 - Flags: feedback?(mwu)
Blocks: 997596
Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Hi Michael,

Few bugs found in nightly build.
Attachment is my updated patch, please help to review it.
Thanks!
Attachment #8404585 - Flags: feedback?(mwu) → review?(mwu)
Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Looks fine. I'd just like the kernel module part removed - I think we should focus on getting the kernel to compile instead.
Attachment #8404585 - Flags: review?(mwu) → review+
Hi Michael,

The reason I think we shall not build kernel in our side is trying to avoid the issues induced from kernel change. Take NFC for example, partner modifies some codes that we can only use partner's library instead of codeaurora build to make NFC works.

If you still think kernel build is perferred, I would like to new another bug to enable it after more testing.
Flags: needinfo?(mwu)
Yeah, that's fine. Full image flashing already runs the risk of introducing new issues, so this doesn't worry me. A new bug would be better - everything else in the PR is fine so we should get it landed.
Flags: needinfo?(mwu)
Keywords: checkin-needed
You didn't actually remove the kernel module from the extraction script.
Keywords: checkin-needed
An unreviewed fix for bug 1000581 was also added to the PR.
Sorry that i mess 2 bugs in one PR, close it first.

        Attachment #8404585 -
        Attachment is obsolete: true

    
  
Blocks: 1000682

    
    

    
  
remove kernel module in PR and new a bug 1000682 for tracking.
Keywords: checkin-needed

    
    

    
  
Master: https://github.com/mozilla-b2g/device-flame/commit/af76f744d4ba92af8438058e653de1e0916259a1
Status: NEW → RESOLVED
Closed: 10 years ago

          status-b2g-v2.0:
          --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: