994577 - [flame] audio didn't work in nightly build system.img

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[viral [:viralwang]]

after flash complete image in bug 978888, audio didn't work
I can open music app and play, but can't hear anything.

Comment 1

[viral [:viralwang]]

Attachment: add audio files to make audio work

Hi Michael,

Could you please help review this patch?
Thanks.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Request review again after addressing reviewing comments on PR.

Comment 3

[viral [:viralwang]]

Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Hi Michael,

Few questions need your suggestions on PR.
Could you please help on it?
Thanks!

Comment 4

[viral [:viralwang]]

Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Hi Michael,

Few bugs found in nightly build.
Attachment is my updated patch, please help to review it.
Thanks!

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 8404585 [details] [review]
add audio files to make audio work

Looks fine. I'd just like the kernel module part removed - I think we should focus on getting the kernel to compile instead.

Comment 6

[viral [:viralwang]]

Hi Michael,

The reason I think we shall not build kernel in our side is trying to avoid the issues induced from kernel change. Take NFC for example, partner modifies some codes that we can only use partner's library instead of codeaurora build to make NFC works.

If you still think kernel build is perferred, I would like to new another bug to enable it after more testing.

Comment 7

[Michael Wu [:mwu]]

Yeah, that's fine. Full image flashing already runs the risk of introducing new issues, so this doesn't worry me. A new bug would be better - everything else in the PR is fine so we should get it landed.

Comment 8

[Michael Wu [:mwu]]

You didn't actually remove the kernel module from the extraction script.

Comment 9

[Michael Wu [:mwu]]

An unreviewed fix for bug 1000581 was also added to the PR.

Comment 10

[viral [:viralwang]]

Sorry that i mess 2 bugs in one PR, close it first.

Comment 11

[viral [:viralwang]]

Attachment: updated PR for bug 994577

Comment 12

[viral [:viralwang]]

remove kernel module in PR and new a bug 1000682 for tracking.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/device-flame/commit/af76f744d4ba92af8438058e653de1e0916259a1