994622 - [Build] Ignore network error when trying to fetch the node_modules from github

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Julien Wajsberg [:julienw]]

Currently, whenever we change branch, if the node_modules hash changed between the 2 branches, the makefile goals will want to download the new one.

Now, most of the time the change is not meaningful to just build a profile therefore it's probably safe to ignore.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: github PR

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

and there is a travis error for marionette_js, but I think it isn't caused by your change.

Comment 3

[Julien Wajsberg [:julienw]]

Got a green travis, merging :) Thanks !

Comment 4

[Julien Wajsberg [:julienw]]

master: 2f947be0ca2a64aa142c0d2e8305cc6d41f9121f

Comment 5

[Julien Wajsberg [:julienw]]

a=tests
v1.4: c78d1ab13586da4db62690fab915cf8256d09c35