994648 - Enhance closeAllTabs() with a force argument which will use an API to close tabs instead of relying on UI actions

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Andrei Eftimie]

Module:    teardownModule
Test:      /testAwesomeBar/testSwitchToTab.js    
Failure:   Tab has been closed
Branches:  default
Platforms: OSX 10.6
http://mozmill-daily.blargon7.com/#/functional/report/7ab760e27012969ae02e3b9e4199b5ce

Failed several times, all on OSX 10.6, Nightly across locales.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Somewhat a regression on OS X 10.6 only? I also have seen 2 failures yesterday.

Comment 2

[Andrei Eftimie]

(In reply to Henrik Skupin (:whimboo) from comment #1)
> Somewhat a regression on OS X 10.6 only? I also have seen 2 failures
> yesterday.

I've also seen this locally while preparing and testing the skip patch for bug 994040 two days ago: http://mozmill-crowd.blargon7.com/#/functional/failure?app=All&branch=All&platform=All&from=2014-04-04&to=2014-04-11&test=%2FtestAwesomeBar%2FtestSwitchToTab.js&func=teardownModule

I'll check if I can still reproduce it.

Comment 3

[Andrei Eftimie]

Attachment: bookmark_panel.png

I can reproduce it.
Intermittent but with a 30-40% reproducibility rate.

The problem lies in one of the previous tests, in testSuggestBookmarks.js which sometimes has a "Page Bookmarked" panel open. This interferes with our ability to close the tabs in testSwitchToTab.js

Comment 4

[Andrei Eftimie]

I'm guessing we fail to click the Done button[1] as we only wait for a DOM node attribute to be present (Or we click it to early and it doesn't have the proper events attached). We fail to wait enough until the Panel is opened and that this issue is a fallout from bug 994040.

[1] http://hg.mozilla.org/qa/mozmill-tests/file/233878149561/firefox/tests/functional/testAwesomeBar/testSuggestBookmarks.js#l53

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hm, I think the closeAllTabs() method needs a force option, which makes use of the tab API to close the tabs. So we do not have to go through the UI, which can cause failures like this.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I think we should transform this bug to make closeTabs() failure-proof. Otherwise it would be a dupe of bug 994040.

Comment 7

[Andrei Eftimie]

Lets do that.

Relevant function: http://hg.mozilla.org/qa/mozmill-tests/file/233878149561/firefox/lib/tabs.js#l513

This should also receive an argument `aForce` which when `true` should forcibly close all tabs via an API and not depend on any UI element.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This parameter would also be necessary for TabBrowser.closeTab().

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Mozmill is dead, WONTFIX the remaining bugs.