Open Bug 994741 Opened 11 years ago Updated 1 year ago

Clean-up: IonMonkey: visitAddI should check the MIR to add overflow checks.

Categories

(Core :: JavaScript Engine: JIT, enhancement, P5)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

People

(Reporter: nbp, Unassigned)

References

(Blocks 1 open bug)

Details

Currently, all CodeGenerator functions are checking if we have a snapshot to add an overflow check or not. This is a bad practice because the information is not determine by the Lowering, and the Lowering might be wrong. We should change this code to check for a MAdd::overflow() function on the MIR instruction.
Severity: normal → S3

We should replace the ins->snapshot() calls from the CodeGenerator by ins->mir()->fallible() calls.

Blocks: sm-opt-jits
Severity: S3 → N/A
Type: defect → enhancement
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.