994750 - [Australis] "Show All History" unreadable on certain dark Linux theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Alexander Usyskin]

When using "Mediterranean Darkest" theme on Linux "Show All History" footer of history from australis menu is dark gray on slightly darker gray, so almost unreadable. Similar footers in bookmarks menu are fine.

Comment 1

[Aleksandr Seleznev]

Attachment: Patch

Without ";" this line [1] looks bad in any case. %)

1: http://hg.mozilla.org/mozilla-central/rev/5d90aed97e13#l1.233

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8481887 [details] [diff] [review]
Patch

Review of attachment 8481887 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ -764,5 @@
>    margin: 4px -4px -4px;
>    background-color: hsla(210,4%,10%,.07);
>    border-top: 1px solid hsla(210,4%,10%,.12);
>    border-radius: 0;
> -  color: hsl(0,0%,25%)

I'm afraid this is not the correct fix! The following would probably be better:

```css
.subviewbutton.panel-subview-footer,
.subviewbutton.panel-subview-footer > .toolbarbutton-text {
  color: hsl(0,0%,25%);
}
```

and remove the line you removed already in this patch.

But before you submit a new patch, I'd like to know why the color value above is not inherited by the button label on Linux. Could you investigate that?

BTW, omitting the semicolon on the last statement in a style definition block is legal syntax and often used by CSS minifiers to shave off a few bytes.

Comment 3

[Aleksandr Seleznev]

Attachment: Screenshots (xfce-dusk)

(In reply to Mike de Boer [:mikedeboer] from comment #2)

Excuse me, but I think that you didn't understand the problem. Can you look on
screenshots in attachment? I think history footer should looks like bookmarks
footer. Am I right in this part?

Comment 4

[Aleksandr Seleznev]

Attachment: Patch (v2)

However, I agreed that my v1 patch looks too bad. I made another. %)

Comment 5

[Mike de Boer [:mikedeboer]]

(In reply to Alexander Seleznev from comment #3)
> Excuse me, but I think that you didn't understand the problem. Can you look
> on
> screenshots in attachment? I think history footer should looks like bookmarks
> footer. Am I right in this part?

Yes, it should.

Comment 6

[Aleksandr Seleznev]

This bug was fixed in bug 1081071. Not sure what to do with this bug.