994758 - Rename tabHeight define in browser.inc to tabMinHeight

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

"tabHeight" is inaccurate, since it implies a static set height. tabMinHeight is far more accurate.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Like this, Dao?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks!

remote:   https://hg.mozilla.org/integration/fx-team/rev/f52627a1e98e

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f52627a1e98e

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8404842 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Bug 990218, which I just requested uplift approval for as well.


User impact if declined: 

None, whatsoever. This is just the renaming of a define to something a little clearer that Dao preferred.


Testing completed (on m-c, etc.): 

A few days on m-c.


Risk to taking this patch (and alternatives if risky): 

Non-existent.


String or IDL/UUID changes made by this patch:

None.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/d957194188cc


Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/9eca66ee5b10