994799 - Require PersistentRooted objects give a name for their root

Status: NEW

(Core :: JavaScript: GC, enhancement, P5)

Description

[Andrew McCreight [:mccr8]]

PersistentRooted is a really great interface for rooting stuff, but it would be nice if it stored a name along with it for GC log purposes.  Hopefully there aren't so many of these that it makes a difference for memory usage.

I'll try to throw a prototype together.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Named rooted stuff, WIP

This seems to work.  People may object to the very boilerplatey named argument.  Another nasty problem is that when you create a persistent rooted with a nullptr as the second argument, that ends up in the case where the name pointer is null, and you end up in a null deref whenever you try to mark it.  I had to fix a number of these.  It would be nice if that was a compile error.  But anyways, this seems to work.

Comment 2

[Jon Coppeard (:jonco)]

Looks good!