994841 - Create (or modify) mocha reporter that streams results over a socket

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Andrew Halberstadt [:ahal]]

This is needed for bug 994764.

I've created an initial prototype here:
https://github.com/ahal/mocha-tbpl-reporter/tree/python_service

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Mocha socket reporter

Hey Gareth, would you mind giving this a quick review? I basically copied the mocha-tbpl-reporter and made the necessary changes. Once it's reviewed I'll transfer it over to the mozilla-b2g user.

Comment 2

[Andrew Halberstadt [:ahal]]

Ah, it's not a pull request so not redirecting. Here's the url for convenience:
https://github.com/ahal/mocha-socket-reporter

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8451919 [details] [diff] [review]
Mocha socket reporter

Hey looks good! A couple things...

(1) You pass the class / function that creates the thing (not an instance/object) to mocha which knows nothing about your socket goodness so the address param will always be undefined.

(2) nit: Keys in js objects don't need quotes :)... neither do key references (ie my.var === my['var'])

Other than that things look great!

Comment 4

[Andrew Halberstadt [:ahal]]

(In reply to Gareth Aye [:gaye] from comment #3)
> (1) You pass the class / function that creates the thing (not an
> instance/object) to mocha which knows nothing about your socket goodness so
> the address param will always be undefined.

Right, I'll just remove it then.

> 
> (2) nit: Keys in js objects don't need quotes :)... neither do key
> references (ie my.var === my['var'])

Yeah, I wasn't really sure which way was preferred. I take it my.var is.

> Other than that things look great!

Thanks for the quick feedback! I'll have some more code for you to look at shortly in other bugs. For future reference, do you want to handle all reviews like this? Or is there anyone else I should spread them out to?

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

I'm happy to do reviews for you. James Lal [:lightsofapollo] is also a module owner for marionette js, so feel free to loop him in too.

Comment 6

[Andrew Halberstadt [:ahal]]

I transferred the repo to mozilla-b2g, but now I can't commit to it (even though I'm on the chefs team). Thanks github.. Anyway, I'm calling this bug done for now. Will file new bugs for future issues.

Comment 7

[Andrew Halberstadt [:ahal]]

Link to new repo:
https://github.com/mozilla-b2g/mocha-socket-reporter