Closed Bug 994989 Opened 6 years ago Closed 6 years ago

Move Save as pdf to the Page menu

Categories

(Firefox for Android :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 31

People

(Reporter: wesj, Assigned: mcomella)

Details

Attachments

(1 file, 1 obsolete file)

Save as pdf is in the tools menu for historical reasons. It really makes a whole lot more sense in the page menu.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Comment on attachment 8406293 [details] [diff] [review]
Move Save as PDF to Page menu.

Review of attachment 8406293 [details] [diff] [review]:
-----------------------------------------------------------------

There's two ther menus that need updated:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml#78

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml#79

(Yes this is annoying...) I don't see any tests for this...
Attachment #8406293 - Flags: review?(wjohnston) → review-
Sorry, that was sloppy on my part. Questions:
  * Should I remove the drawable file?
  * Should I be removing "android:icon" (as I'm doing)? It seems to be ignored,
and, if we don't remove the drawable, it'd be harder to forget the drawable
exists (though, I guess it might require more runtime resources).
Attachment #8406313 - Flags: review?(wjohnston)
Attachment #8406293 - Attachment is obsolete: true
(In reply to Wesley Johnston (:wesj) from comment #2)
> (Yes this is annoying...) I don't see any tests for this...

Created bug 996227.
Attachment #8406313 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/c80c6685d1e0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Verified as fixed on Nightly 31.0a1(2014-04-16).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.