994989 - Move Save as pdf to the Page menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Save as pdf is in the tools menu for historical reasons. It really makes a whole lot more sense in the page menu.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Move Save as PDF to Page menu.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8406293 [details] [diff] [review]
Move Save as PDF to Page menu.

Review of attachment 8406293 [details] [diff] [review]:
-----------------------------------------------------------------

There's two ther menus that need updated:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/menu-large-v11/browser_app_menu.xml#78

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/menu-xlarge-v11/browser_app_menu.xml#79

(Yes this is annoying...) I don't see any tests for this...

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Move Save as PDF to Page menu. v2

Sorry, that was sloppy on my part. Questions:
  * Should I remove the drawable file?
  * Should I be removing "android:icon" (as I'm doing)? It seems to be ignored,
and, if we don't remove the drawable, it'd be harder to forget the drawable
exists (though, I guess it might require more runtime resources).

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Wesley Johnston (:wesj) from comment #2)
> (Yes this is annoying...) I don't see any tests for this...

Created bug 996227.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/c80c6685d1e0

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c80c6685d1e0

Comment 7

[u421692]

Verified as fixed on Nightly 31.0a1(2014-04-16).

Comment 8

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

added to https://docs.google.com/a/mozilla.com/spreadsheet/ccc?key=0Amy0OSD97CR6dGF4ZkhVaFFnaEI1cWhpR0dyM1hlaUE&usp=drive_web#gid=3 for joni savage to document in SUMO