99503 - Add XP support for connecting to an OS/2 FTP server

Status: VERIFIED WONTFIX

(Core Graveyard :: Networking: FTP, defect)

Description

[Mike Kaply [:mkaply]]

Adding support for connecting to an OS/2 FTP server.

Diff attached.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Add a new FTP server type for OS/2

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 49238 [details] [diff] [review]
Add a new FTP server type for OS/2

over all, looks good.

in the converter code, don't use PL_strstr, but instead use PL_strnstr.  nit, you might want to check the error code of ToInterger?

Comment 3

[Mike Kaply [:mkaply]]

I'll make the change to use PL_strnstr.

I did a quick glance through lxr, and it doesn't look like anyone checks the 
errors ToInteger.

It seems like it wasn't architected well to do that.

Who is the right sr for this?

Thanks

Comment 4

[Doug Turner (:dougt)]

Darin, can you sr this patch?

Comment 5

[Darin Fisher]

the patch is marked "needs-work" ... can you submit a final patch?

Comment 6

[Mike Kaply [:mkaply]]

Attachment: New patches per dougt - use strnstr - Note there are lots of other places in this file that use strstr

Comment 7

[Darin Fisher]

Comment on attachment 49665 [details] [diff] [review]
New patches per dougt - use strnstr - Note there are lots of other places in this file that use strstr

sr=darin

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in

Comment 9

[jag (Peter Annema)]

So, using strnstr is good, if you also provide the "n" part of it ;-)

Comment 10

[Mike Kaply [:mkaply]]

In my silly mind, I was thinking strnstr was case insensitive strstr. So I did 
the substution blindly.

Stupid mistake totally my on my part.

I put strstr back in to fix the bustage.

Will redo a fix and check it in this afternoon.

Comment 11

[Doug Turner (:dougt)]

reassigning to [e-mail].

Comment 12

[Bradley Baetz (:bbaetz)]

-> mkaply for the additional patch

Comment 13

[benc]

+makingtest: Is there a public OS/2 ftp server you can put in the URL page?

Comment 14

[Mike Kaply [:mkaply]]

I'm working to get one setup. I should have an answer soon.

Comment 15

[Mike Kaply [:mkaply]]

OS/2 FTP is working.

I don't think the strstr needs to be fixed unless someone wants to do it for 
this entire file.

Comment 16

[Mike Kaply [:mkaply]]

Os/2 ftp is working great.