995034 - Contact UI screens are not properly hidden for screen reader

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Eitan Isaacson [:eeejay]]

By swiping through the interface, the user could being up all the different screens that are transformed out of view.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Redirecting to a contact peer.

BTW looks like this is breaking some marionette-js tests.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Almost there, left some comments on github.

Mainly we have a problem, of going throug a pathd of the code that can try to execute a null callback.

But tiny change and we are ready to land this. Ask me for review once the changes are applied.

Thanks a lot for the collaboration!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Forgot to mention, can you add some unit test (or reuse the current ones) to check when the class 'current' should be or not be there?

Thanks!

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

I had to redo a lot of unit tests. Since we need to be completely async, and waif for callbacks, having global variables for "current" and "next" does not work well.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Relaunching the marionette tests

Comment 7

[Eitan Isaacson [:eeejay]]

Green.

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

German I know you were the last one doing a big refactor in the navigation object.

Would you mind giving feedback about the patch?

I already did the review but will appreciate your feedback here.

Comment 9

[Eitan Isaacson [:eeejay]]

German, any chance for feedback soon?

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Hi guys! Sorry for the delay, mainly to Eitan :-) Looking good to me and much cleaner than the previous code so congrats! ;-)

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Relaunch travis jobs to land this.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Adding my self as needinfo to remember to land this :)

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

\o/ green travis!

Thanks a lot Eitan

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/a4e2793dbee7b71bcf4786fb37be7369b2b34cfb