Closed Bug 995034 Opened 6 years ago Closed 6 years ago

Contact UI screens are not properly hidden for screen reader

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eeejay, Unassigned)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=2])

Attachments

(1 file)

By swiping through the interface, the user could being up all the different screens that are transformed out of view.
Whiteboard: [b2ga11y 2.0]
Blocks: 995497
Whiteboard: [b2ga11y 2.0] → [b2ga11y p=2]
Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Redirecting to a contact peer.

BTW looks like this is breaking some marionette-js tests.
Attachment #8425155 - Flags: review?(etienne) → review?(francisco.jordano)
Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Almost there, left some comments on github.

Mainly we have a problem, of going throug a pathd of the code that can try to execute a null callback.

But tiny change and we are ready to land this. Ask me for review once the changes are applied.

Thanks a lot for the collaboration!
Attachment #8425155 - Flags: review?(francisco.jordano) → review-
Forgot to mention, can you add some unit test (or reuse the current ones) to check when the class 'current' should be or not be there?

Thanks!
Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

I had to redo a lot of unit tests. Since we need to be completely async, and waif for callbacks, having global variables for "current" and "next" does not work well.
Attachment #8425155 - Flags: review- → review?(francisco.jordano)
Relaunching the marionette tests
Green.
Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

German I know you were the last one doing a big refactor in the navigation object.

Would you mind giving feedback about the patch?

I already did the review but will appreciate your feedback here.
Attachment #8425155 - Flags: review?(francisco)
Attachment #8425155 - Flags: review+
Attachment #8425155 - Flags: feedback?(gtorodelvalle)
German, any chance for feedback soon?
Comment on attachment 8425155 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/19398

Hi guys! Sorry for the delay, mainly to Eitan :-) Looking good to me and much cleaner than the previous code so congrats! ;-)
Attachment #8425155 - Flags: feedback?(gtorodelvalle) → feedback+
Relaunch travis jobs to land this.
Adding my self as needinfo to remember to land this :)
Flags: needinfo?(francisco)
\o/ green travis!

Thanks a lot Eitan
Flags: needinfo?(francisco)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.