Closed Bug 995037 Opened 11 years ago Closed 11 years ago

Migration logic to convert Notes (master) data format to Notes+ (phase2)

Categories

(Firefox OS Graveyard :: Gaia::Notes, defect)

defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: yor, Assigned: yor)

Details

Attachments

(1 file)

44 bytes, text/x-github-pull-request
matias
: review+
Details | Review
This will allow us to upgrade the Notes app to the latest Notes+ code.
Comparing data formats between Notes and Notes+, here are the transformations we need: 1. User object - none required 2. Notebooks - none required 3. Notes without resources - convert data_text to data_content (enml format) - add data_active:true - add data_resources:[] 4. Notes with resources - in addition to #3, add <en-media> node to end of data_content for each resource - add resource entry to data_resources for each resource - convert base64 encoded resource data to ArrayBuffer and generate appropriate hash 5. All object ids remain the same
Matias/Ran, please provide feedback. Thanks.
Flags: needinfo?(ran)
Flags: needinfo?(matias)
Assignee: nobody → yor
Status: NEW → ASSIGNED
Leaving the review for Matias
Flags: needinfo?(ran)
Attached file Pull request
Attachment #8407633 - Flags: review?(matias)
Comment on attachment 8407633 [details] [review] Pull request Yan, i went over the code, I couldn't test it on a device but it looks good to me... If you have a way to test it on a device let me know how and i'll test it. Good job.
Attachment #8407633 - Flags: review?(matias) → review+
Flags: needinfo?(matias)
Matias, To test the migration: 1. Install the master branch build to your device 2. Create some notes 3. Update the app with the latest phase2 + this batch to your device 4. Data will be migrated when you open a note or when you do the first sync I use App Manager to install and update the app.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: