995093 - Add a marionette test to check Keyboard app could show up correctly.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Evan Tseng [:evanxd]]

Add a marionette test to check Keyboard app could show up correctly.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

We have gaia-ui-tests that already cover this.

Comment 2

[Evan Tseng [:evanxd]]

Hi Jan,

Yes, but we also need this test in js-marionette.
And this bug is blocking Bug 993247.

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/18207

Hi Evan, 
   Please help to review this patch, thanks.

Comment 4

[Evan Tseng [:evanxd]]

Hi Gary,

Just left comments for your patch.
Nice work! :)

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/18219

Please review this patch again. thanks.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8405294 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18219

Hi Gary,
The https://travis-ci.org/mozilla-b2g/gaia/jobs/22761579 travis job wasn't passed.

Comment 7

[Evan Tseng [:evanxd]]

Hi Gary,

Have some nits.
Please refer to 
https://github.com/evanxd/gaia/blob/mpizza-bug-995093/apps/keyboard/test/marionette/lib/keyboard_tests.js
https://github.com/evanxd/gaia/blob/mpizza-bug-995093/apps/keyboard/test/marionette/keyboardtests/index.html
https://github.com/evanxd/gaia/blob/mpizza-bug-995093/apps/keyboard/test/marionette/keyboard_launch_test.js

Thanks.

Comment 8

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/18253

Comment 9

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/18241

Hi Evan,
   I can not see any comments what you list links on comment #7, could you left you comment again?

   Thanks

Comment 10

[Evan Tseng [:evanxd]]

Rudy is helping to debug the intermittent issues.

Comment 11

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Comment on attachment 8405842 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18241

Hi Evan,
   I just clean up this patch, please review it again.
   I'll re-run travis after bug 997045 is landed.

   thanks.

Comment 12

[Evan Tseng [:evanxd]]

We could review the patch after Bug 997045 is done.
Thanks.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Please be informed that I've sent another pull request for stability check, which already contains the patches in Bug 997045.
 - https://github.com/mozilla-b2g/gaia/pull/18443

For the keyboard marionette-js test itself, it still needs some changes as the commit shows,
https://github.com/RudyLu/gaia/commit/71d3202684d91b086080eed5a350f0f3a59a2dad

Comment 14

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Rudy and Evan,
   I just addressed your comments on my patch please help to take a look.
   https://github.com/mozilla-b2g/gaia/pull/18241
   Thanks.

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Thanks for incorporating my changes into the patch.
BTW, the tests are not going to pass since my patches into marionette-apps is not merged yet, and we're working on that.

Comment 16

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8405842 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18241

Just comment on the pull request with some suggestions/nits.
Thanks.

Comment 17

[Evan Tseng [:evanxd]]

We should just wait for Bug 997045 is fixed, then we could review the patch.
Thanks.

Comment 18

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Evan and Rudy,
   Thanks for your wonderful works on bug 997045.
   I just update my code base and trigger travis again.

   Please help to reive my patch thanks.
   https://travis-ci.org/mozilla-b2g/gaia/builds/24083761

Comment 19

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yeah, I also did the stability test again with the latest Gaia change,
https://github.com/mozilla-b2g/gaia/pull/18443

Need Evan's help to review it again and then we could merge this change!

Comment 20

[Evan Tseng [:evanxd]]

Left comments in the GitHub page.

Comment 21

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Evan:
   Travis looks good can I get r+?
   https://travis-ci.org/mozilla-b2g/gaia/builds/24092483
   https://travis-ci.org/mozilla-b2g/gaia/builds/24093269

   Thanks~

Comment 22

[Evan Tseng [:evanxd]]

Comment on attachment 8405842 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/18241

Hi Gary,
r+, nice work!

Comment 23

[Evan Tseng [:evanxd]]

master: 1aeff97ba68fdb0fc36eaa29627bf1834043c7e3

Comment 24

[Evan Tseng [:evanxd]]

Hi Gary and Rudy,

Do you guys have badg.us accounts?
You got the Marionette Starter awards.
http://badg.us/en-US/badges/badge/Marionette-Starter

Comment 25

[Evan Tseng [:evanxd]]

We finally have marionette tests for keyboard app. It will let us have less regression. Nice!

Comment 26

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #24)
> Hi Gary and Rudy,
> 
> Do you guys have badg.us accounts?
> You got the Marionette Starter awards.
> http://badg.us/en-US/badges/badge/Marionette-Starter

Sure, my account is [e-mail].
Thanks again.

Comment 27

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Evan, Gary,

Thanks for making this happen.

--
I'll send Evan my account info to get the badge. :)

Comment 28

[Evan Tseng [:evanxd]]

You got it.
http://badg.us/en-US/badges/badge/Marionette-Starter