995157 - Tabs opened in guest mode can be synced

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Environment:
Build 31.0a1 (2014-04-10)
Devices: Nexus 4(4.4.2) and Asus Transformer (Android 4.2.1)

Steps to reproduce:
1. Set up a new Firefox Account and log in on two devices.
2. Start Firefox on one device, switch to a Guest session and navigate to a site.
3. Force a Sync.
4. On the second device go to synced tabs.

Expected result: 
The tab opened in guest session doesn't appear at synced tabs on the second device.

Actual result:
The tab opened in guest session appear at synced tabs on the second device.

Comment 1

[Nick Alexander :nalexander [he/him]]

If Fennec writes the tab record to the DB, Sync will see it and include it in the outbound tabs upload.  My guess is that Fennec shouldn't be writing the tab record: since the tabs DB is strictly for Sync's use, non-Sync items shouldn't be written; but I'll need to investigate.

ni to me to investigate and re-file as a Fennec issue if necessary; ni to wesj for a comment about use of the tabs DB, since I believe he implemented much of guest mode.

Comment 2

[Nick Alexander :nalexander [he/him]]

This sure looks like Bug 957131 for the tabs content provider.  Changed assumptions for the loss :|

Comment 3

[Nick Alexander :nalexander [he/him]]

wesj: yep, this is an android-sync thing.  Bug 957131 squashed some, but not all, the issues.  I'm going to audit the remaining places before posting patches.

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/454

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #4)
> Created attachment 8409271 [details] [review]
> Link to Github pull-request:
> https://github.com/mozilla-services/android-sync/pull/454

Works well locally (at least the tabs part; I didn't dig in to the clients part too deeply).

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8409271 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/454

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  Don't know. Presumably it's been a while.
 
User impact if declined: 
  Interplay between Guest Mode use and tab sync leads to data leakage.

Testing completed (on m-c, etc.): 
  Hasn't landed yet, just getting this request in early!

Risk to taking this patch (and alternatives if risky): 
  Should be slim -- it adds the correct 'profile' argument to the URIs that Sync uses to talk to the tabs database.

String or IDL/UUID changes made by this patch:
  None.

Comment 7

[Nick Alexander :nalexander [he/him]]

In an email thread, rnewman raised the question of whether tabs are written to the DB during guest browsing, and whether they accumulate or are purged.  Tabs are written to the DB during guest browsing, and the entire guest profile is deleted at the end of the guest session, so they are purged.

Comment 8

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/f6b4679502a9

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f6b4679502a9

Comment 10

[Cristina Madaras, QA [:CristinaM]]

I'm not able to reproduce this anymore on Nightly (2014-04-08), using Nexus 4 (Android 4.4.2) and Asus Transformer (Android 4.2.1). This seems to be fixed.

Comment 11

[Cristina Madaras, QA [:CristinaM]]

I wanted to say Nightly (2014-04-21). Sorry for that!

(In reply to cristina.madaras from comment #10)
> I'm not able to reproduce this anymore on Nightly (2014-04-08), using Nexus
> 4 (Android 4.4.2) and Asus Transformer (Android 4.2.1). This seems to be
> fixed.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ac6669c6e0d