Closed
Bug 99518
Opened 24 years ago
Closed 24 years ago
template files do not have license headers
Categories
(Bugzilla :: Bugzilla-General, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: myk, Assigned: gerv)
References
()
Details
Attachments
(1 file)
|
12.14 KB,
patch
|
myk
:
review+
myk
:
review+
|
Details | Diff | Splinter Review |
The template files in the template/default sub-directory do not contain license
headers even though they are licensed under the same terms (MPL) as the rest of
the code in the Bugzilla distribution. All of the following files should have
MPL license headers:
attachment/
edit.atml
list.atml
updated.atml
viewall.atml
attachstatus/
create.atml
edit.atml
list.atml
Comments in template files use the pound sign (#) within directive tags ([% %]),
for example:
[% DIRECTIVE STATEMENT HERE # single line comment %]
or...
[%# multi
line
comment
%]
Multi-line comments occur when the pound sign appears just after the opening tag.
Updated•24 years ago
|
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
Comment 1•24 years ago
|
||
This is going to be a blocker for the 2.16 release
Severity: major → blocker
| Assignee | ||
Comment 2•24 years ago
|
||
Let's not let any more in without headers, OK? :-)
Looking for r=myk.
Gerv
| Assignee | ||
Updated•24 years ago
|
| Reporter | ||
Comment 5•24 years ago
|
||
Comment on attachment 57550 [details] [diff] [review]
Fixes it for all Myk's templates
I suck, Gerv rocks, r=myk. No second review needed, but don't get bit by the
addition of the license header for updated.atml in bug 98110. They may cause
false conflicts when applying both patches.
Attachment #57550 -
Flags: review+
| Assignee | ||
Comment 6•24 years ago
|
||
Checked in.
Gerv
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•