995283 - [Messages][Refactoring] Investigate alternative ways to host attachment inside compose area other than 'iframe'.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

Using iframe to host attachment inside contenteditable compose field works well, but involves a bunch of magic, has bigger memory footprint and makes code more complex than it could be. 

We should think of alternative ways to do this. One of ideas is to draw thumbnail+filename+filesize into a single canvas and use toDataURL instead of iframe.

See bug 889899 for more details on reasons behind iframe.

Comment 1

[Julien Wajsberg [:julienw]]

(In reply to Oleg Zasypkin [:azasypkin] from comment #0)
> 
> We should think of alternative ways to do this. One of ideas is to draw
> thumbnail+filename+filesize into a single canvas and use toDataURL instead
> of iframe.

Or just display the canvas itself ;)

Comment 2

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> (In reply to Oleg Zasypkin [:azasypkin] from comment #0)
> > 
> > We should think of alternative ways to do this. One of ideas is to draw
> > thumbnail+filename+filesize into a single canvas and use toDataURL instead
> > of iframe.
> 
> Or just display the canvas itself ;)

Yep, should also work!

Comment 3

[Oleg Zasypkin [:azasypkin]]

One more approach that we probably can try: https://developer.mozilla.org/en-US/docs/HTML/Canvas/Drawing_DOM_objects_into_a_canvas

Comment 4

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 5

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(