Make Bing/Yahoo partner codes consistent across channels

RESOLVED FIXED in Firefox 32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconnor, Assigned: mconnor)

Tracking

unspecified
Firefox 32
x86_64
Windows 8
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Comment on attachment 8408584 [details] [diff] [review]
nightlyAuroraCodes

* Bing can just be hardcoded
* For Yahoo it's much easier to change the pref (there are a _lot_ of localized plugins in play here).
* Hooray tests.
Attachment #8408584 - Flags: review?(gavin.sharp)
Comment on attachment 8408584 [details] [diff] [review]
nightlyAuroraCodes

>diff --git a/browser/branding/aurora/pref/firefox-branding.js b/browser/branding/aurora/pref/firefox-branding.js

>+// code usage depends on contracts, please contact the Business Affairs team if you have questions

How about "Don't change these without explicit signoff from the Firefox module owner"? Seems more likely to stand the test of time :)

How about moving these prefs to firefox.js now that they're the same regardless of branding?

> pref("browser.search.param.yahoo-fr-cjkt", ""); // now unused

Non-existent prefs seems to be handled fine by the search service (MozParam is ignored), so might as well clean this up?

> pref("browser.search.param.yahoo-f-CN", "");

Is this unused too?

r=me with those changes.
Attachment #8408584 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/38bf66433fc6
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
mconnor, do you remember why we left yahoo-fr as a pref-based MozParams, rather than just hardcoding the values we need in yahoo.xml? Do some distros or locales set the prefs still?
Flags: needinfo?(mconnor)
Long-overdue, but I think it was because of how some partner builds worked.  I think it's all obsolete now.
Flags: needinfo?(mconnor)
You need to log in before you can comment on or make changes to this bug.