Open Bug 995407 Opened 6 years ago Updated 6 years ago

Re-enable wifi and cell tower data reporting on release builds.

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

REOPENED
Tracking Status
firefox31 + wontfix
firefox32 + wontfix

People

(Reporter: ggp, Assigned: ggp)

Details

Attachments

(2 files)

Now that bug 903535 has landed, it should be possible to re-enable this on release builds. While we still need to do some work on bug 995361 to get the data collection/reporting code up-to-date, the current version is still usable, so I believe it makes sense to re-enable it now.
The patch is a first attempt at this, and looks pretty much consistent with the patch on bug 909938, but I couldn't verify for sure that it works: the best documentation I could find on making a release build was [1], but changing milestone.txt manually to something like 31.0.0 didn't seem to work.

Surely there's a better way I'm not aware of :)

1- https://wiki.mozilla.org/Platform/Channel-specific_build_defines
Attachment #8405592 - Flags: feedback?(blassey.bugs) → feedback+
The way I'd test this would be to remove lines 3602-3607 from configure.in
Comment on attachment 8405592 [details] [diff] [review]
Re-enable wifi/cell tower data reporting on release builds.

Seems to be working then, after testing with the changes to configure.in

Try run: https://tbpl.mozilla.org/?tree=Try&rev=824027d1e9a4
Attachment #8405592 - Flags: review?(blassey.bugs)
Attachment #8405592 - Flags: review?(blassey.bugs) → review+
Keywords: checkin-needed
Assignee: nobody → ggoncalves
https://hg.mozilla.org/mozilla-central/rev/b90d50c9d8be
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
turns out that turning this on for release and beta was premature, we need to back this out across the board
Attachment #8439632 - Flags: review?(mark.finkle)
Comment on attachment 8405592 [details] [diff] [review]
Re-enable wifi/cell tower data reporting on release builds.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:
Attachment #8405592 - Flags: approval-mozilla-beta?
Attachment #8405592 - Flags: approval-mozilla-aurora?
Attachment #8439632 - Flags: review?(mark.finkle) → review+
Brad, could you fill the Approval Request Comment ? Thanks
Flags: needinfo?(blassey.bugs)
This is turning off code that is broken, doesn't provide user benefit and doesn't justify a permission bump
Flags: needinfo?(blassey.bugs)
Attachment #8405592 - Flags: approval-mozilla-beta?
Attachment #8405592 - Flags: approval-mozilla-beta+
Attachment #8405592 - Flags: approval-mozilla-aurora?
Attachment #8405592 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.