Closed Bug 995454 Opened 6 years ago Closed 6 years ago

Kill off TextureClientSurface's GetAsSurface and UpdateSurface methods

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We can get rid of TextureClientSurface's GetAsSurface and UpdateSurface methods now.
Attached patch patchSplinter Review
Attachment #8405621 - Flags: review?(matt.woodrow)
Comment on attachment 8405621 [details] [diff] [review]
patch

Review of attachment 8405621 [details] [diff] [review]:
-----------------------------------------------------------------

Can't we just kill TextureClientSurface entirely?
Attachment #8405621 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0662c5d9963

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Can't we just kill TextureClientSurface entirely?

I was going to, but this is what I had sitting in my patch queue and I thought it best to get it into the tree rather than sitting on it to finish it after getting back from my PTO.
(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Comment on attachment 8405621 [details] [diff] [review]
> patch
> 
> Review of attachment 8405621 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can't we just kill TextureClientSurface entirely?

I have a patch that does that, to land it I just need to fix TestTextures.cpp that uses TextureClientSurface, which I did in anither patch but the latter breaks on try so I need to look into it.
https://hg.mozilla.org/mozilla-central/rev/c0662c5d9963
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.