995454 - Kill off TextureClientSurface's GetAsSurface and UpdateSurface methods

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

We can get rid of TextureClientSurface's GetAsSurface and UpdateSurface methods now.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8405621 [details] [diff] [review]
patch

Review of attachment 8405621 [details] [diff] [review]:
-----------------------------------------------------------------

Can't we just kill TextureClientSurface entirely?

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0662c5d9963

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Can't we just kill TextureClientSurface entirely?

I was going to, but this is what I had sitting in my patch queue and I thought it best to get it into the tree rather than sitting on it to finish it after getting back from my PTO.

Comment 4

[Nicolas Silva [:nical]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Comment on attachment 8405621 [details] [diff] [review]
> patch
> 
> Review of attachment 8405621 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Can't we just kill TextureClientSurface entirely?

I have a patch that does that, to land it I just need to fix TestTextures.cpp that uses TextureClientSurface, which I did in anither patch but the latter breaks on try so I need to look into it.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c0662c5d9963