995458 - [B2G][Tarako][Settings] 'Caller ID' and 'Call waiting' settings are not saved for individual SIM cards

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[demerick]

Attachment: call_setting_logcat.txt

Description:
If the user enters Call Settings with two SIM cards in the device they will get the option to choose which SIM they want to configure. After choosing a SIM, changing the 'Call waiting' or 'Caller ID' settings will change the settings for BOTH SIM cards.

Repro Steps:

Pre-requisites -  two active SIM cards

1) Update a Tarako to BuildID: 20140411004003 and insert two SIM cards
2) Tap 'Settings' from the home screen
3) Tap 'Call Settings' and tap 'SIM 1'
4) Wait for settings to load and enable 'Call waiting'
5) Tap the back arrow in the top left corner of the screen
6) Tap 'SIM 2' and disable 'Call waiting' after the settings load
7) Tap the back arrow in the top left corner of the screen
8) Tap 'SIM 1' and observe 'Call waiting' setting

Actual:
SIM 1 'Call waiting' setting is changed 

Expected:
Only SIM 2 'Call waiting' setting is changed

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140411004003
Gaia: 27a0e773e01eed74e20709bdcab6894469f42a72
Gecko: 257dd37da601
Version: 28.1
Firmware Version: SP8810

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/10682/
See attached: logcat, firewatch

Video URL: http://youtu.be/xAOLsqqM-zA

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 981989 hasn't landed in 1.3T.  I'm not sure the risk involved in taking it.  noming

Comment 2

[Jason Smith [:jsmith]]

This shouldn't block. A lot of the individual SIM management use cases for DSDS to my understanding was planned for 1.4, not 1.3.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

IIRC, this is by design in 1.3, let's confirm with Arthur on the implementation of 1.3. if so, let's close this bug. thanks

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Call waiting and caller ID should work in v1.3.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like the fix hasn't landed in 1.3.  If it's by design in 1.3 then I guess we should close this off as a dup of bug 981989

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+, after talking to arthur this is a bug.

Comment 8

[James Ho]

Arthur, what's the fix plan here?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

The caller id issue depends on bug 997584. However, I'm not able to reproduce the call waiting issue. (http://youtu.be/Gt6d31rPdu0)

Gaia      718a06816327fcb6a18095f677cfff4b86adc292
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/7e764399b4fc
BuildID   20140415164003
Version   28.1
ro.build.version.incremental=eng.cltbld.20140415.201139
ro.build.date=Tue Apr 15 20:11:46 EDT 2014

Comment 10

[William Hsu [:whsu]]

I can reproduce it.
I have contacted Arthur, and gave the Tarako device.
Thanks.

Please re-mark QAwanted if anyone have further question.
Thanks!

Comment 11

[William Hsu [:whsu]]

While system is requesting network information(SIM1) then switch to the other SIM card (SIM2) settings, 
You will see SIM2's status synchronize the SIM1's status.
The unconfirmed network status causes the problem. (Bug 997584)
Thanks.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

The call waiting issue is due to the latency of querying states from the carrier. If users try to navigate to the panel of another sim card before the query completed, the states of the previous sim card is displayed.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/18447

The patch tries to solve the UI refresh issue of sharing the same ui page across two sim cards. A context management mechanism helps ensure that the result of the last query is displayed on the UI. Jose, could you help review the patch? Thanks!

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Arthur Chen [:arthurcc] from comment #13)
> Created attachment 8408861 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/18447

The patch LGTM but I'd like to test it on a real device. I'll test on a fugu device as I don't have a tarako one. Arthur, I'll get back to you ASAP. Thanks.

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8408861 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18447

Thanks for the patch Arthur. Left a comment in the PR.

Note: Sadly I won't be able to test this patch on a DSDS device until next week. The device we have in the office is broken (doesn't not boot at all). I will test the work with a single ICC card device (Peak). Sorry for the inconveniences.

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8408861 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18447

The patch has been rewritten to address the issue you brought up. In the end I queue the async tasks and execute them in sequential order. And redundant tasks will not be executed as well.

Please use the w=1 url (https://github.com/mozilla-b2g/gaia/pull/18447/files?w=1) to check the patch, thanks!

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/18666

PR against v1.3t.

Comment 18

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8408861 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18447

This approach works like a charm, thanks for this Arthur. r=me

As I commented on previous comments I don't have a multi ICC card device so I tested this on peak. I really thrush Arthur and I don't think this patch brakes anything on a multi ICC card device.

Comment 19

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8412386 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18666

This approach works like a charm as well, thanks for this Arthur. Tested on buri device running v1.3. r=me

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Arthur, what's the next step for this bug?

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #5)
> Looks like the fix hasn't landed in 1.3.  If it's by design in 1.3 then I
> guess we should close this off as a dup of bug 981989

should we switch to status-1.3 -> wontfix?

Comment 21

[Arthur Chen [:arthurcc][inactive after 6/30]]

We need to support DSDS for call waiting and caller id restriction in v1.3. The proposed patch in comment 13 solves the call waiting part. The caller id restriction part is being handled in bug 997584. I'll mark this one as resolved once bug 997584 lands.

Joe, should we uplift this to v1.3?

Comment 22

[Joe Cheng [:jcheng] (please needinfo)]

ni? Bhavana / Fabrice on 1.3

Comment 23

[[:fabrice] Fabrice Desré]

I'm fine with taking that on 1.3, but you need to ask approval on the patch.

Comment 24

[Preeti Raghunath(:Preeti)]

We haven't seen this as an IOT/ cert blocker and hence leaving out for 1.3.

Comment 25

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 7a638fc49d62c6c8cf0892b13b2c20c54e3d67bb

Comment 26

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.3t: 557b6f81bbf792f99c58fe663441a9f8b7f90a4a

Tested with the build 20140511164002, it still failed on the caller id part. As gaia and gecko have addressed the problem, hsinyi suspects there is a problem on the modem side. Land the gaia patch first.

Comment 27

[ying.xu]

add sam
Please check Comment 26

Comment 28

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to ying.xu from comment #27)
> add sam
> Please check Comment 26

You could also refer to https://bugzilla.mozilla.org/show_bug.cgi?id=997584#c36 for log.

Comment 29

[William Hsu [:whsu]]

Thanks all.
Verified it.

* Build information:
 - Build ID  20140519164002
 - Gaia      917174ee3812a43758bf43f7ba5f9416dcdb2ca8
 - Gecko     a3a14fb5ad51

Comment 30

[Ivan Tsay (:ITsay)]

Hi Arthur,

Is this patch landed in v1.4?

Comment 31

[Arthur Chen [:arthurcc][inactive after 6/30]]

No, it is not. And all the dependent bugs are not in v1.4 as well.

Comment 32

[Ivan Tsay (:ITsay)]

Comment on attachment 8408861 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/18447

Hi Preeti,

Per our discussion during the meeting, I send the approval request for this fix to be uplifted to v1.4. For the approval comment, please refer to bug 997601 comment here https://bugzilla.mozilla.org/show_bug.cgi?id=997601#c39

Comment 33

[Ivan Tsay (:ITsay)]

(In reply to Ivan Tsay (:ITsay) from comment #32)
> Comment on attachment 8408861 [details]
> Link to https://github.com/mozilla-b2g/gaia/pull/18447
> 
> Hi Preeti,
> 
> Per our discussion during the meeting, I send the approval request for this
> fix to be uplifted to v1.4. For the approval comment, please refer to bug
> 997601 comment here https://bugzilla.mozilla.org/show_bug.cgi?id=997601#c39

Meant to say comment https://bugzilla.mozilla.org/show_bug.cgi?id=997601#c42 in bug 997601

Comment 34

[(PTO June 19-July 7) Ryan VanderMeulen]

Needs rebasing for v1.4 uplift.

Comment 35

[Arthur Chen [:arthurcc][inactive after 6/30]]

The patch depends on the patch of bug 997601. I'll provide a PR against v1.4 after bug 997601 lands on v1.4.

Comment 36

[(PTO June 19-July 7) Ryan VanderMeulen]

Any time now :)

Comment 37

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v1.4

Note that we can land the patch when it passes gaia try but should not mark the bug as fixed until bug 997584 gets fixed on v1.4. :)

Comment 38

[(PTO June 19-July 7) Ryan VanderMeulen]

I'm very confused on the uplift/blocking/approval status of all these bugs, so it's probably going to be best if you just handle them at this point.

Comment 39

[Ivan Tsay (:ITsay)]

Comment on attachment 8442553 [details]
PR against v1.4

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): DSDS feature
[User impact] if declined: See user impact on comment 39
[Testing completed]: verified in bug 995458
[Risk to taking this patch] (and alternatives if risky): Low, since QA already the test cases on this 
[String changes made]:No change

Comment 40

[(PTO June 19-July 7) Ryan VanderMeulen]

v1.4: https://github.com/mozilla-b2g/gaia/commit/214e724ec79697d55bed63432bb1818a6291990f