Closed Bug 995509 Opened 7 years ago Closed 7 years ago

[l10n][eu] Use Spanish and French layouts by default for eu

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tchevalier, Assigned: tchevalier)

Details

(Whiteboard: LocRun1.4)

Attachments

(1 file)

It seems we don't have any keyboard layout for eu (Basque) locale.
Where can that be defined? FWIW there's no such thing as a Basque keyboard, but users would expect a Spanish or French keyboard depending on the region they are.
(In reply to Julen Ruiz Aizpuru from comment #1)
> Where can that be defined? FWIW there's no such thing as a Basque keyboard,
> but users would expect a Spanish or French keyboard depending on the region
> they are.

Great, thanks for the input Julen! I've asked around and flod pointed me to this config file https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json
I will update it as follow:

    "eu": [
        {"layoutId": "es", "app": ["apps", "keyboard"]}
        {"layoutId": "fr", "app": ["apps", "keyboard"]}
    ],

Does that sounds good to you? (es and fr keyboards included, es by default.)
Summary: [l10n][eu] Missing keyboard for eu → [l10n][eu] Use Spanish and French layouts by default for eu
Assignee: nobody → tchevalier
Status: NEW → ASSIGNED
Attachment #8406233 - Flags: review?(rlu)
(In reply to Théo Chevalier [:tchevalier] from comment #2)
> 
> Great, thanks for the input Julen! I've asked around and flod pointed me to
> this config file
> https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-
> layouts.json
> I will update it as follow:
> 
>     "eu": [
>         {"layoutId": "es", "app": ["apps", "keyboard"]}
>         {"layoutId": "fr", "app": ["apps", "keyboard"]}
>     ],
> 
> Does that sounds good to you? (es and fr keyboards included, es by default.)

Any chance to set the default depending on the region? Getting an 'es' layout in a phone bought in France would look odd (not sure how likely this situation is though). Having 'en' as a third layout would help as well.
(In reply to Julen Ruiz Aizpuru from comment #4)
> (In reply to Théo Chevalier [:tchevalier] from comment #2)
> > 
> > Great, thanks for the input Julen! I've asked around and flod pointed me to
> > this config file
> > https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-
> > layouts.json
> > I will update it as follow:
> > 
> >     "eu": [
> >         {"layoutId": "es", "app": ["apps", "keyboard"]}
> >         {"layoutId": "fr", "app": ["apps", "keyboard"]}
> >     ],
> > 
> > Does that sounds good to you? (es and fr keyboards included, es by default.)
> 
> Any chance to set the default depending on the region? Getting an 'es'
> layout in a phone bought in France would look odd (not sure how likely this
> situation is though). Having 'en' as a third layout would help as well.

Hm. Not sure we can set layouts per region, I'm gonna ask.

Yeah, I wasn't sure about having "en" as fallback, I'll update the PR, thanks!
(In reply to Théo Chevalier [:tchevalier] from comment #5)
> Hm. Not sure we can set layouts per region, I'm gonna ask.

It is indeed not possible at the moment :/
I was afraid of that — is there any bug to implement support for region-specific defaults?

For now let's go for 'es', 'fr', 'en'.
(In reply to Julen Ruiz Aizpuru from comment #7)
> I was afraid of that — is there any bug to implement support for
> region-specific defaults?

Not that I'm aware of... Feel free to open it

> 
> For now let's go for 'es', 'fr', 'en'.
 ok
Comment on attachment 8406233 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18293

r=me.

Thanks.

The unit tests are failed, but should be irrelevant, will merge this if the rerun is ok.
Attachment #8406233 - Flags: review?(rlu) → review+
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/fab9c55b2f529ba7cf99e755edd9ff7624f8cebd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.