995509 - [l10n][eu] Use Spanish and French layouts by default for eu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Théo Chevalier]

It seems we don't have any keyboard layout for eu (Basque) locale.

Comment 1

[Julen Ruiz Aizpuru]

Where can that be defined? FWIW there's no such thing as a Basque keyboard, but users would expect a Spanish or French keyboard depending on the region they are.

Comment 2

[Théo Chevalier]

(In reply to Julen Ruiz Aizpuru from comment #1)
> Where can that be defined? FWIW there's no such thing as a Basque keyboard,
> but users would expect a Spanish or French keyboard depending on the region
> they are.

Great, thanks for the input Julen! I've asked around and flod pointed me to this config file https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json
I will update it as follow:

    "eu": [
        {"layoutId": "es", "app": ["apps", "keyboard"]}
        {"layoutId": "fr", "app": ["apps", "keyboard"]}
    ],

Does that sounds good to you? (es and fr keyboards included, es by default.)

Comment 3

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18293

Comment 4

[Julen Ruiz Aizpuru]

(In reply to Théo Chevalier [:tchevalier] from comment #2)
> 
> Great, thanks for the input Julen! I've asked around and flod pointed me to
> this config file
> https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-
> layouts.json
> I will update it as follow:
> 
>     "eu": [
>         {"layoutId": "es", "app": ["apps", "keyboard"]}
>         {"layoutId": "fr", "app": ["apps", "keyboard"]}
>     ],
> 
> Does that sounds good to you? (es and fr keyboards included, es by default.)

Any chance to set the default depending on the region? Getting an 'es' layout in a phone bought in France would look odd (not sure how likely this situation is though). Having 'en' as a third layout would help as well.

Comment 5

[Théo Chevalier]

(In reply to Julen Ruiz Aizpuru from comment #4)
> (In reply to Théo Chevalier [:tchevalier] from comment #2)
> > 
> > Great, thanks for the input Julen! I've asked around and flod pointed me to
> > this config file
> > https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-
> > layouts.json
> > I will update it as follow:
> > 
> >     "eu": [
> >         {"layoutId": "es", "app": ["apps", "keyboard"]}
> >         {"layoutId": "fr", "app": ["apps", "keyboard"]}
> >     ],
> > 
> > Does that sounds good to you? (es and fr keyboards included, es by default.)
> 
> Any chance to set the default depending on the region? Getting an 'es'
> layout in a phone bought in France would look odd (not sure how likely this
> situation is though). Having 'en' as a third layout would help as well.

Hm. Not sure we can set layouts per region, I'm gonna ask.

Yeah, I wasn't sure about having "en" as fallback, I'll update the PR, thanks!

Comment 6

[Théo Chevalier]

(In reply to Théo Chevalier [:tchevalier] from comment #5)
> Hm. Not sure we can set layouts per region, I'm gonna ask.

It is indeed not possible at the moment :/

Comment 7

[Julen Ruiz Aizpuru]

I was afraid of that — is there any bug to implement support for region-specific defaults?

For now let's go for 'es', 'fr', 'en'.

Comment 8

[Théo Chevalier]

(In reply to Julen Ruiz Aizpuru from comment #7)
> I was afraid of that — is there any bug to implement support for
> region-specific defaults?

Not that I'm aware of... Feel free to open it

> 
> For now let's go for 'es', 'fr', 'en'.
 ok

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8406233 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18293

r=me.

Thanks.

The unit tests are failed, but should be irrelevant, will merge this if the rerun is ok.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/fab9c55b2f529ba7cf99e755edd9ff7624f8cebd