995532 - [camera] buttons don't consistently highlight when tapped

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR

Open camera and take a few photos
Go into preview and select delete
Tap either cancel or delete

Expected
Blue highlight state

Actual
The highlight only works some of the time

Comment 1

[Justin D'Arcangelo [:justindarc]]

These buttons are simply relying on the CSS :active state to change their highlight color. A patch for Bug 986752 was landed last week to resolve issues with :active states getting stuck, but I think there are remaining issues in Gecko with CSS :active states.

Comment 2

[Wilson Page [:wilsonpage]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #1)
> These buttons are simply relying on the CSS :active state to change their
> highlight color. A patch for Bug 986752 was landed last week to resolve
> issues with :active states getting stuck, but I think there are remaining
> issues in Gecko with CSS :active states.

justin: Do you know which component we should move this to? Did you make any graphics friends in your :active travels?

Comment 3

[Justin D'Arcangelo [:justindarc]]

Wilson: The issues I was working on with :active were dealing with multiple touches causing it to remain 'stuck' (see Bug 997235). Vivien was the one who patched it, but I'm almost certain it wasn't a graphics issue as much as it was an events issue.

Comment 4

[Tiffanie Shakespeare [:tif]]

It seems like this applies to more than just the delete confirmation dialogue. We are seeing it in many places.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Several other CSS :active bugs that may be related and/or require discussion:

Bug 997235 - Followup to bug 986752 - CSS :active states get stuck with multiple on-screen touches
Bug 1009684 - Define a UX specification for handling CSS :active states on touch devices

Comment 6

[Stephany Wilkes]

Chatted with Rob and we think this needs a look from Casey.

Comment 7

[Wilson Page [:wilsonpage]]

This is a platform bug relating to CSS :active state. This should *not* be worked around at the Camera/Gaia layer. See justindarc's comment 5.

Comment 8

[Tiffanie Shakespeare [:tif]]

How do we push this issue to the right people?

Comment 9

[Stephany Wilkes]

Removing the flag for Casey based on comment #7 and Hema is already flagged to reassign to a Platform dev.

Comment 10

[Hema Koka [:hema]]

Andrew,

Based on the comments and related bugs on css :active state, moving this to Core->DOM. Please help triage this into the right component and find an owner for this issue.

Thanks
Hema

Comment 11

[Justin D'Arcangelo [:justindarc]]

CSS :active states seem to be *completely* broken using latest nightly. Simple test case with a couple buttons with :active styles here: http://jsbin.com/vorib

Comment 12

[Boris Zbarsky [:bzbarsky]]

> CSS :active states seem to be *completely* broken using latest nightly. 

On which OS? Your testcase works fine for me in todays nightly on OSX....

Comment 13

[Justin D'Arcangelo [:justindarc]]

Firefox OS

Comment 14

[Justin D'Arcangelo [:justindarc]]

CSS :active states seem to be way more broken than usual today:

https://www.youtube.com/watch?v=t9PqdLsNdMo

Using latest build on Nexus4:

Gaia      101c500903a2477f9de1ea5ce523b9e0be4d45d0
Gecko     https://hg.mozilla.org/mozilla-central/rev/41a54c8add09
BuildID   20140519040204
Version   32.0a1

Comment 15

[Andrew Overholt [:overholt]]

kats says bug 1013378 should fix most of the recent :active bustage (likely regressed by bug 964750).

Comment 16

[Hema Koka [:hema]]

(In reply to Andrew Overholt [:overholt] from comment #15)
> kats says bug 1013378 should fix most of the recent :active bustage (likely
> regressed by bug 964750).

qawanted to test it out with above fixes in.

Comment 17

[Roland Kunkel [:RolandK]]

This issue DOES reproduce on the latest v2.0 Flame build:

Environmental Variables:
Device: Flame 2.0
BuildID: 20140609040203
Gaia: 12af93123c5db55212d51fe235d39f21209a1eaa
Gecko: 9305a8ec77fe
Version: 32.0a1
Firmware Version: V10G-2

-

Cancel and Delete do not always turn blue when the user 'taps' them. While testing, these buttons only appeared blue when I held the buttons before selecting them.

Comment 18

[Tiffanie Shakespeare [:tif]]

Is this still valid or should we close? Thanks!

Comment 19

[Sylvestre Ledru [:Sylvestre]]

I don't think we are going to work on this anymore. Closing.