995777 - browser.properties: rename getUserMedia.videoDevice.prompt to reflect new string

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Francesco Lodolo [:flod]]

Noticed only today while importing strings in my translation memory

http://hg.mozilla.org/mozilla-central/diff/af15bd900a2a/mobile/android/locales/en-US/chrome/browser.properties

-getUserMedia.videoDevice.prompt = Camera to use
+getUserMedia.videoDevice.prompt = Video source

We should set a new ID.

Comment 1

[Francesco Lodolo [:flod]]

Normally (Firefox or Gaia) I'd fix this myself, but I never touched mobile code and time is running short.

Brad, can you please take a look before it slips in Aurora?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: videoSource_prompt.patch

note: I can't test this right now
note #2: this bumps several entities whose strings haven't actually changed because of how we construct the entity IDs in the code

Comment 3

[Francesco Lodolo [:flod]]

The tabstream string is part of the other bug ;-)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8409073 [details] [diff] [review]
videoSource_prompt.patch

>diff --git a/mobile/android/locales/en-US/chrome/browser.properties b/mobile/android/locales/en-US/chrome/browser.properties

> #Tab sharing
>-tabstream.title = Choose a tab to stream
>+tabstream.picker.title = Choose a tab to stream

Revert this change

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch for checkin

since the trees are closed and I don't trust myself to get this landed before merge gonna use checkin-needed

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/0096df4879f7

Comment 7

[Carsten Book [:Tomcat]]

sorry Brad had to backout this change for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=38388052&tree=Fx-Team

Comment 8

[Francesco Lodolo [:flod]]

Just to note that this one slipped into Aurora :-\

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e2bba39c0385

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing bug 1006913.
https://hg.mozilla.org/integration/fx-team/rev/3838be7a8148

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Brad - You missed changing this one:
http://mxr.mozilla.org/mozilla-central/source/content/media/webrtc/MediaEngineTabVideoSource.cpp#112

which causes this:
[JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" {file: "chrome://browser/content/WebrtcUI.js" line: 130}]

Comment 12

[Francesco Lodolo [:flod]]

Friendly reminder. Can we fix this?

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

https://tbpl.mozilla.org/?tree=Try&rev=658f1aaa877c

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: video_source_prompt.patch

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/956b626ee498