Closed
Bug 995777
Opened 10 years ago
Closed 10 years ago
browser.properties: rename getUserMedia.videoDevice.prompt to reflect new string
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: flod, Assigned: blassey)
References
Details
Attachments
(1 file, 2 obsolete files)
2.95 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Noticed only today while importing strings in my translation memory http://hg.mozilla.org/mozilla-central/diff/af15bd900a2a/mobile/android/locales/en-US/chrome/browser.properties -getUserMedia.videoDevice.prompt = Camera to use +getUserMedia.videoDevice.prompt = Video source We should set a new ID.
Reporter | ||
Comment 1•10 years ago
|
||
Normally (Firefox or Gaia) I'd fix this myself, but I never touched mobile code and time is running short. Brad, can you please take a look before it slips in Aurora?
Flags: needinfo?(blassey.bugs)
Assignee | ||
Comment 2•10 years ago
|
||
note: I can't test this right now note #2: this bumps several entities whose strings haven't actually changed because of how we construct the entity IDs in the code
Assignee: nobody → blassey.bugs
Attachment #8409073 -
Flags: review?(mark.finkle)
Flags: needinfo?(blassey.bugs)
Reporter | ||
Comment 3•10 years ago
|
||
The tabstream string is part of the other bug ;-)
Comment 4•10 years ago
|
||
Comment on attachment 8409073 [details] [diff] [review] videoSource_prompt.patch >diff --git a/mobile/android/locales/en-US/chrome/browser.properties b/mobile/android/locales/en-US/chrome/browser.properties > #Tab sharing >-tabstream.title = Choose a tab to stream >+tabstream.picker.title = Choose a tab to stream Revert this change
Attachment #8409073 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 5•10 years ago
|
||
since the trees are closed and I don't trust myself to get this landed before merge gonna use checkin-needed
Attachment #8411085 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0096df4879f7
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 7•10 years ago
|
||
sorry Brad had to backout this change for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=38388052&tree=Fx-Team
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Comment 8•10 years ago
|
||
Just to note that this one slipped into Aurora :-\
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e2bba39c0385
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Comment 10•10 years ago
|
||
Backed out for causing bug 1006913. https://hg.mozilla.org/integration/fx-team/rev/3838be7a8148
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 32 → ---
Comment 11•10 years ago
|
||
Brad - You missed changing this one: http://mxr.mozilla.org/mozilla-central/source/content/media/webrtc/MediaEngineTabVideoSource.cpp#112 which causes this: [JavaScript Error: "NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" {file: "chrome://browser/content/WebrtcUI.js" line: 130}]
Reporter | ||
Comment 12•10 years ago
|
||
Friendly reminder. Can we fix this?
Flags: needinfo?(blassey.bugs)
Assignee | ||
Comment 13•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=658f1aaa877c
Flags: needinfo?(blassey.bugs)
Assignee | ||
Comment 14•10 years ago
|
||
Attachment #8409073 -
Attachment is obsolete: true
Attachment #8411085 -
Attachment is obsolete: true
Attachment #8429568 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8429568 -
Flags: review?(mark.finkle) → review+
Comment 15•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/956b626ee498
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•