995847 - mach should accept "--help" as well as a top-level "help" command

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Cameron McCormack (:heycam)]

I (and others apparently) habitually pass "--help" to mach to find out about top-level commands or arguments to commands, and then realise I have to re-run the command with "help" instead.  It would be great if we fixed this papercut and accepted --help too.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: 0001-Bug-995847-Add-h-and-help-support-to-mach.patch

Comment 2

[(no longer active)]

Comment on attachment 8414354 [details] [diff] [review]
0001-Bug-995847-Add-h-and-help-support-to-mach.patch

gps is away...

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8414354 [details] [diff] [review]
0001-Bug-995847-Add-h-and-help-support-to-mach.patch

Review of attachment 8414354 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of hackish, but not much worse than how arguments are handled anyways.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Add -h and --help support to mach.

Add r=glandium to the commit message, and carry over r+.

Mike, thanks for reviewing my patch!

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Since I only modified the mach build script, it should be sufficient to test only the build on various platforms.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=e197fe0cc0b2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da3a67552b81

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/da3a67552b81