Closed Bug 995847 Opened 6 years ago Closed 5 years ago

mach should accept "--help" as well as a top-level "help" command

Categories

(Firefox Build System :: Mach Core, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: heycam, Assigned: TYLin)

Details

Attachments

(1 file, 1 obsolete file)

I (and others apparently) habitually pass "--help" to mach to find out about top-level commands or arguments to commands, and then realise I have to re-run the command with "help" instead.  It would be great if we fixed this papercut and accepted --help too.
Assignee: nobody → tlin
Attachment #8414354 - Flags: review?(gps)
Comment on attachment 8414354 [details] [diff] [review]
0001-Bug-995847-Add-h-and-help-support-to-mach.patch

gps is away...
Attachment #8414354 - Flags: review?(gps) → review?(mh+mozilla)
Comment on attachment 8414354 [details] [diff] [review]
0001-Bug-995847-Add-h-and-help-support-to-mach.patch

Review of attachment 8414354 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of hackish, but not much worse than how arguments are handled anyways.
Attachment #8414354 - Flags: review?(mh+mozilla) → review+
Add r=glandium to the commit message, and carry over r+.

Mike, thanks for reviewing my patch!
Attachment #8414354 - Attachment is obsolete: true
Attachment #8418482 - Flags: review+
Since I only modified the mach build script, it should be sufficient to test only the build on various platforms.

Try result:
https://tbpl.mozilla.org/?tree=Try&rev=e197fe0cc0b2
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/da3a67552b81
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.