995972 - New mochitest-devtools mach command doesn't allow to run single folders or files

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Patrick Brosset <:pbro>]

Since today, on fx-team, command `mach mochitest-browser` doesn't allow to run the devtools tests anymore, which I think is expected since we now have `mach mochitest-devtools`.

However, although the command works fine to run all the tests in the suite, it doesn't seem to work for running a single directory or file:

- Running `mach mochitest-devtools browser/devtools/markupview/test/` returns:
From _tests: Kept 16010 existing; Added/updated 0; Removed 0 files and 0 directories.
No tests could be found in the path specified. Please specify a path that is a test file or is a directory containing tests.

- Running `mach mochitest-devtools browser/devtools/markupview/test/browser_markupview_html_edit_03.js` returns:
From _tests: Kept 16010 existing; Added/updated 0; Removed 0 files and 0 directories.
No tests could be found in the path specified. Please specify a path that is a test file or is a directory containing tests.

Of course, if I remove `subsuite = devtools` in browser.ini, then running the tests with `mochitest-browser` works as before.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: fix-mochitest-devtools-with-path-995972.patch

Part of the mochitest-dt patch for bug 984930 that didn't make it across.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8406150 [details] [diff] [review]
fix-mochitest-devtools-with-path-995972.patch

Review of attachment 8406150 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/testing.py
@@ +91,5 @@
>          def fltr(tests):
>              for test in tests:
> +                if flavor and \
> +                   (flavor == 'devtools' and test.get('flavor') != 'browser-chrome') or \
> +                   (flavor != 'devtools' and test.get('flavor') != flavor):

this was in the original patch, probably checked in the version prior to this.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/e6b103b4369e

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #3)
> https://hg.mozilla.org/integration/fx-team/rev/e6b103b4369e

Sorry: https://hg.mozilla.org/integration/fx-team/rev/a3337bda5a22

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for mozbuild test failures.
https://hg.mozilla.org/integration/fx-team/rev/c3cec8a150a0

https://tbpl.mozilla.org/php/getParsedLog.php?id=37760491&tree=Fx-Team

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fixed dodgy if statement

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Try:
https://tbpl.mozilla.org/?tree=Try&rev=4dc49ab9ddb9

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8406737 [details] [diff] [review]
Fixed dodgy if statement

Review of attachment 8406737 [details] [diff] [review]:
-----------------------------------------------------------------

this is as clear as you can get now.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/a9d48e622da8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9d48e622da8