Closed Bug 995972 Opened 9 years ago Closed 9 years ago

New mochitest-devtools mach command doesn't allow to run single folders or files

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: pbro, Assigned: miker)

References

Details

Attachments

(1 file, 1 obsolete file)

Since today, on fx-team, command `mach mochitest-browser` doesn't allow to run the devtools tests anymore, which I think is expected since we now have `mach mochitest-devtools`.

However, although the command works fine to run all the tests in the suite, it doesn't seem to work for running a single directory or file:

- Running `mach mochitest-devtools browser/devtools/markupview/test/` returns:
From _tests: Kept 16010 existing; Added/updated 0; Removed 0 files and 0 directories.
No tests could be found in the path specified. Please specify a path that is a test file or is a directory containing tests.

- Running `mach mochitest-devtools browser/devtools/markupview/test/browser_markupview_html_edit_03.js` returns:
From _tests: Kept 16010 existing; Added/updated 0; Removed 0 files and 0 directories.
No tests could be found in the path specified. Please specify a path that is a test file or is a directory containing tests.

Of course, if I remove `subsuite = devtools` in browser.ini, then running the tests with `mochitest-browser` works as before.
Assignee: nobody → mratcliffe
Blocks: 984930
Part of the mochitest-dt patch for bug 984930 that didn't make it across.
Attachment #8406150 - Flags: review?(jmaher)
Component: Developer Tools → Mochitest Chrome
Product: Firefox → Testing
Comment on attachment 8406150 [details] [diff] [review]
fix-mochitest-devtools-with-path-995972.patch

Review of attachment 8406150 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/testing.py
@@ +91,5 @@
>          def fltr(tests):
>              for test in tests:
> +                if flavor and \
> +                   (flavor == 'devtools' and test.get('flavor') != 'browser-chrome') or \
> +                   (flavor != 'devtools' and test.get('flavor') != flavor):

this was in the original patch, probably checked in the version prior to this.
Attachment #8406150 - Flags: review?(jmaher) → review+
Status: NEW → ASSIGNED
Attachment #8406150 - Attachment is obsolete: true
Attachment #8406737 - Flags: review?(jmaher)
Comment on attachment 8406737 [details] [diff] [review]
Fixed dodgy if statement

Review of attachment 8406737 [details] [diff] [review]:
-----------------------------------------------------------------

this is as clear as you can get now.
Attachment #8406737 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/a9d48e622da8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
Component: Mochitest Chrome → Mochitest
You need to log in before you can comment on or make changes to this bug.