Closed
Bug 995972
Opened 11 years ago
Closed 11 years ago
New mochitest-devtools mach command doesn't allow to run single folders or files
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: pbro, Assigned: miker)
References
Details
Attachments
(1 file, 1 obsolete file)
1.26 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Since today, on fx-team, command `mach mochitest-browser` doesn't allow to run the devtools tests anymore, which I think is expected since we now have `mach mochitest-devtools`.
However, although the command works fine to run all the tests in the suite, it doesn't seem to work for running a single directory or file:
- Running `mach mochitest-devtools browser/devtools/markupview/test/` returns:
From _tests: Kept 16010 existing; Added/updated 0; Removed 0 files and 0 directories.
No tests could be found in the path specified. Please specify a path that is a test file or is a directory containing tests.
- Running `mach mochitest-devtools browser/devtools/markupview/test/browser_markupview_html_edit_03.js` returns:
From _tests: Kept 16010 existing; Added/updated 0; Removed 0 files and 0 directories.
No tests could be found in the path specified. Please specify a path that is a test file or is a directory containing tests.
Of course, if I remove `subsuite = devtools` in browser.ini, then running the tests with `mochitest-browser` works as before.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mratcliffe
Assignee | ||
Comment 1•11 years ago
|
||
Part of the mochitest-dt patch for bug 984930 that didn't make it across.
Attachment #8406150 -
Flags: review?(jmaher)
Updated•11 years ago
|
Component: Developer Tools → Mochitest Chrome
Product: Firefox → Testing
Comment 2•11 years ago
|
||
Comment on attachment 8406150 [details] [diff] [review]
fix-mochitest-devtools-with-path-995972.patch
Review of attachment 8406150 [details] [diff] [review]:
-----------------------------------------------------------------
::: python/mozbuild/mozbuild/testing.py
@@ +91,5 @@
> def fltr(tests):
> for test in tests:
> + if flavor and \
> + (flavor == 'devtools' and test.get('flavor') != 'browser-chrome') or \
> + (flavor != 'devtools' and test.get('flavor') != flavor):
this was in the original patch, probably checked in the version prior to this.
Attachment #8406150 -
Flags: review?(jmaher) → review+
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #3)
> https://hg.mozilla.org/integration/fx-team/rev/e6b103b4369e
Sorry: https://hg.mozilla.org/integration/fx-team/rev/a3337bda5a22
Comment 5•11 years ago
|
||
Backed out for mozbuild test failures.
https://hg.mozilla.org/integration/fx-team/rev/c3cec8a150a0
https://tbpl.mozilla.org/php/getParsedLog.php?id=37760491&tree=Fx-Team
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8406150 -
Attachment is obsolete: true
Attachment #8406737 -
Flags: review?(jmaher)
Assignee | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
Comment on attachment 8406737 [details] [diff] [review]
Fixed dodgy if statement
Review of attachment 8406737 [details] [diff] [review]:
-----------------------------------------------------------------
this is as clear as you can get now.
Attachment #8406737 -
Flags: review?(jmaher) → review+
Comment 9•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 10•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
Updated•7 years ago
|
Component: Mochitest Chrome → Mochitest
You need to log in
before you can comment on or make changes to this bug.
Description
•