996072 - APK Factory service should fail with error when manifest and minifest differ incompatibly

Status: RESOLVED FIXED

(Marketplace Graveyard :: Integration, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

The "name, version, developer, and locales fields in your app manifest must be exactly the same as in your mini-manifest" for packaged apps, according to <https://developer.mozilla.org/en-US/Marketplace/Publishing/Packaged_apps#Mini-manifest_fields>.

But APK Factory successfully creates an APK for a packaged app with a manifest/minifest mismatch, per bug 993199.  It should fail with an error instead.

Also see bug 996068.

Comment 1

[Austin King [:ozten]]

Created https://ozten.github.io/misfeasance/

As far as I can tell, the only place this is verified and fails is:
1) Using the browser or FxOS go to https://ozten.github.io/misfeasance/
2) Install App
3) 'download stopped'
4) Click greyed out icon
5) 'download stopped'

Other places I tried to find where validation is enforced:
* Uploading through marketplace creates a new mini-manifest.
* Marketplace manifest validation tools take the packaged app zip file.

Sounds like steps to reproduce for Android will be installs directly from github.

Comment 2

[Austin King [:ozten]]

Fixed in https://github.com/mozilla/apk-factory-service/pull/69

Comment 3

[Iulian Timis]

Is this the expected behavior? http://screencast.com/t/4bsEelH8z
Thank you

Comment 4

[Austin King [:ozten]]

Thanks for your help!

This should be tested on Firefox for Android

Yes, this is expected:
* packaged apps aren't supported on Desktop Firefox (as far as I know)
* Desktop doesn't use the APK Service Factory (which is the focus of this bug)
* Once Desktop supports packaged apps, it should detect the mis-match and refuse to install
* alert of app://{a809e90c-d767-44ee-b11e-1fadf2466947} is just part of the install page javascript

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Packaged apps actually *are* supported on the desktop runtime (the one built into desktop Firefox) and have been since sometime last year.

Comment 6

[Austin King [:ozten]]

Okay, maybe my test packaged apps are broken then.

I'm using this as a sample good packaged app
* http://ozten.github.io/packaged-app/

I'm using this as a sample broken packaged app
* https://ozten.github.io/misfeasance/

Neither app installs for me on Desktop firefox 28 nor Nightly.
Packaged-app's zip file passes the validator at https://marketplace.firefox.com/developers/validator

Any ideas?

Comment 7

[Austin King [:ozten]]

FWIW: Using https://marketplace.firefox.com/developers/test/receipts/ with the following works as expected

* http://ozten.github.io/packaged-app/manifest.webapp
* http://ozten.github.io/misfeasance/manifest.webapp - fails as expected

So maybe I just have a bug in my install page.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

(In reply to Austin King [:ozten] from comment #6)
> Okay, maybe my test packaged apps are broken then.
> 
> I'm using this as a sample good packaged app
> * http://ozten.github.io/packaged-app/

Hmm, the Browser Console reports "error installing webapp: MANIFEST_MISMATCH" at http://mxr.mozilla.org/mozilla-central/source/browser/modules/WebappManager.jsm#147 when I try to install this app on Firefox (desktop), presumably because the name of the app appears to be "Packaged" in the minifest but "Sample Packaged App" in the manifest.

(Firefox doesn't tell the user about the problem, though, which perhaps it should.  We've been relying on stores to communicate such issues to users, but there may be a role for Firefox to play there.  In this case, your "store" doesn't communicate the problem, so it looks like the app install just fails silently.)


> I'm using this as a sample broken packaged app
> * https://ozten.github.io/misfeasance/

This one fails with the same console error, and I didn't dig into why, but presumably it's because this app is intentionally broken!

Comment 9

[Austin King [:ozten]]

Okay, I fixed the manifest inside of ozten.github.io/packaged-app/package.zip

Comment 10

[Austin King [:ozten]]

Maybe the value I have for size is wrong.

If I install on FxOS, it creates an app icon, but stops the download.

http://ozten.github.io/packaged-app/package.zip
size: 15413

ls -al package.zip 

    -rw-r--r-- 1 ozten ozten 15413 Apr 25 12:03 package.zip

Comment 11

[Myk Melez [:myk] [@mykmelez]]

There's another mismatch in the files: the "developer" field, which is the following in the manifest:

  "developer": {
    "name": "Ozten",
    "url": "https://github.com/ozten/misfeasance"
  }

While in the minifest it's:

  "developer": {
    "name": "Ozten",
    "url": "https://github.com/ozten/packaged-app"
  }