996109 - Lazily load some modules in AppsUtils.jsm

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 1

[Marco Castelluccio [:marco]]

https://tbpl.mozilla.org/?tree=Try&rev=84b4c5dfe3d5

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8406287 [details] [diff] [review]
Patch

Review of attachment 8406287 [details] [diff] [review]:
-----------------------------------------------------------------

Does this actually prevent any modules from being loaded? For example, FileUtils.jsm is imported in numerous places, so making one import point lazy probably won't make a difference.

Comment 3

[Marco Castelluccio [:marco]]

This makes WebappOSUtils load lazily (it's already loaded lazily by other consumers)
It doesn't prevent FileUtils from being loaded right away, but since we're moving away from FileUtils sooner or later we're going to load it lazily everywhere.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01530bb2ff64

Comment 5

[Nicholas Nethercote [inactive]]

> This makes WebappOSUtils load lazily (it's already loaded lazily by other
> consumers)
> It doesn't prevent FileUtils from being loaded right away, but since we're
> moving away from FileUtils sooner or later we're going to load it lazily
> everywhere.

Ok, thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01530bb2ff64