Closed Bug 996109 Opened 6 years ago Closed 6 years ago

Lazily load some modules in AppsUtils.jsm

Categories

(Core Graveyard :: DOM: Apps, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: marco, Assigned: marco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #8406287 - Flags: review?(felipc)
Attachment #8406287 - Flags: review?(felipc) → review+
Comment on attachment 8406287 [details] [diff] [review]
Patch

Review of attachment 8406287 [details] [diff] [review]:
-----------------------------------------------------------------

Does this actually prevent any modules from being loaded? For example, FileUtils.jsm is imported in numerous places, so making one import point lazy probably won't make a difference.
This makes WebappOSUtils load lazily (it's already loaded lazily by other consumers)
It doesn't prevent FileUtils from being loaded right away, but since we're moving away from FileUtils sooner or later we're going to load it lazily everywhere.
> This makes WebappOSUtils load lazily (it's already loaded lazily by other
> consumers)
> It doesn't prevent FileUtils from being loaded right away, but since we're
> moving away from FileUtils sooner or later we're going to load it lazily
> everywhere.

Ok, thanks!
https://hg.mozilla.org/mozilla-central/rev/01530bb2ff64
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.