9963 - Locking logic is wrong while in standalone mode

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Doug Turner (:dougt)]

When the XPInstall engine is used in blocking mode:

http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsSoftwareUpdateRun.cpp#2
77

the PR_LOCK fail in RunNextInstall() because the same thread will try to obtain
the lock in a circular manner.

Comment 1

[Daniel Veditz [:dveditz] back 2026-04-08]

Flags of 1 means "force mode" so I fail to see why that determines whether we
spawn a thread or not -- that's probably a bug/test-hack. We should always
spawn a thread, or invent a new flag and bitmask to see the result.

But if running on the same thread is something you want to do for some reason
we could fix the locking order in RunNextInstall() (add several PR_Unlock()s
instead of one at the end).

I'll take this one.

Comment 2

[Jimmy Lee]

This will be and only can be verified when the install wizard uses xpinstall to
install xpis.

Comment 3

[Jimmy Lee]

Build 9/24/99

This installer appears to install properly.  Marking Verified.

Comment 4

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine