Closed Bug 996319 Opened 6 years ago Closed 6 years ago

Drop always-null second arg to nsTextFrame's local GetReferenceRenderingContext function

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

nsTextFrame.cpp has a static helper-function "GetReferenceRenderingContext" whose second argument is always null.

We should just remove the second arg.
Attached patch fix v1Splinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8406504 - Flags: review?(jdaggett)
FWIW: it looks like the last non-null usage of this argument was removed in bug 397518, here:
 http://hg.mozilla.org/mozilla-central/rev/d2943858ac51#l11.125
Depends on: 397518
Attachment #8406504 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/e3756b512314
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.