996346 - Make nsXBLBinding's strong reference to the XBLDocumentInfo less odd

Status: RESOLVED WONTFIX

(Core :: XBL, defect)

Description

[Andrew McCreight [:mccr8]]

Right now, nsXBLBinding calls NS_ADDREF(mPrototypeBinding->XBLDocumentInfo()) in its ctor, NS_RELEASE in its dtor, and does a Traverse (but not an Unlink) of mPrototypeBinding->XBLDocumentInfo().  There's a comment in Unlink: "XXX Probably can't unlink mPrototypeBinding->XBLDocumentInfo(), because mPrototypeBinding is weak."  This comment seems bogus, because we do the release in the dtor without any kind of null check.  In some limited local testing, making this into a regular refPtr field that is unlinked seems to at least sort of work.

Comment 1

[Andrew McCreight [:mccr8]]

comment 0 still seems accurate

Comment 2

[Boris Zbarsky [:bzbarsky]]

XBL is now disabled in Firefox (Bug 1583314) and is in the process of being removed from Gecko (Bug 1566221), so closing bugs requesting changes to its implementation as wontfix.