Closed Bug 996384 Opened 6 years ago Closed 6 years ago
Application#clear Browser Data should not clear app's alarms from moz Alarms
Steps to reproduce: 1. Launch an app. 2. Add an alarm to the system alarms database. 3. Note that you have an alarm in the alarms database. 4. Call clearBrowserData() on the app retrieved from mozApps.getSelf(). 5. Note that you have no alarms in the alarms database. Expected behavior: clearBrowserData() does not delete my app's alarms from the alarms store.
Nominating as a 1.3 blocker since this breaks Google periodic sync in an interesting but nonetheless undesirable way. If this can't be solved in the platform, we can hack around it in calendar in theory, but why make our application code worse when we can instead make the platform better :)?
Fabrice Your input is needed on method of fix of the bug. Technical weigh in needed here
We were also making the same mistake in the PushService code, so I wrapped both fixes in this patch.
Attachment #8407137 - Flags: review?(gene.lian) → review+
Is there a 'superior' call to clearBrowserData() that will indeed delete push and alarms? They seem to be 'private data' to me, especially since alarms can have a 'data' attribute.
(In reply to Nikhil Marathe [:nsm] (needinfo? please) from comment #4) > Is there a 'superior' call to clearBrowserData() that will indeed delete > push and alarms? They seem to be 'private data' to me, especially since > alarms can have a 'data' attribute. Ah sorry! I misunderstood what this is for.
Attachment #8407137 - Flags: review?(nsm.nikhil) → review+
(In reply to Gareth Aye [:gaye] from comment #7) > Resolved fixed? Not until it's on m-c
Ok np. Sorry not super familiar with the mozilla-central workflow.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
https://hg.mozilla.org/releases/mozilla-aurora/rev/981efa650de8 Please request approval-mozilla-b2g28 on the patch for v1.3 uplift when you feel it's sufficiently baked.
*** This bug has been marked as a duplicate of bug 989081 ***
Status: RESOLVED → VERIFIED
Comment on attachment 8407137 [details] [diff] [review] webapps-clear.patch NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): has always been there! User impact if declined: Data loss (alarms and push notifications) Testing completed: yes Risk to taking this patch (and alternatives if risky): no risk String or UUID changes made by this patch: none
Attachment #8407137 - Flags: approval-mozilla-b2g28?
Attachment #8407137 - Flags: approval-mozilla-b2g28? → approval-mozilla-b2g28+
You need to log in before you can comment on or make changes to this bug.