996409 - B2G Network: 'network-active-changed' doesn't be propagated if active becomes to null

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Right now, if |active| becomes to null (which means there is no active network established in system), there is no 'network-active-changed' propagated by NetworkManager. We should fix this, otherwise API user will unable to know the |active| was changed in this case, like [1]. And we also need this for bug 995109.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/push/src/PushService.jsm#477-483

Comment 1

[Edgar Chen [:edgar]]

Attachment: Part 1: 'network-active-changed' doesn't be propagated if active becomes to null, v1

Comment 2

[Edgar Chen [:edgar]]

We definitely need a test case for this. I am working on this now.

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 2: Marionette test for 'network-active-changed', v1

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8406612 [details] [diff] [review]
Part 1: 'network-active-changed' doesn't be propagated if active becomes to null, v1

Review of attachment 8406612 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/NetworkManager.js
@@ +646,5 @@
>  #endif
> +    }
> +
> +    if (this.active != oldActive) {
> +      Services.obs.notifyObservers(this.active, TOPIC_ACTIVE_CHANGED, null);

Good catch!

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8406751 [details] [diff] [review]
Part 2: Marionette test for 'network-active-changed', v1

Review of attachment 8406751 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

Comment 6

[Edgar Chen [:edgar]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=be3888c388d8

Comment 7

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/fe7d26409026
https://hg.mozilla.org/integration/b2g-inbound/rev/c48e44a0e5d1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe7d26409026
https://hg.mozilla.org/mozilla-central/rev/c48e44a0e5d1