Closed
Bug 996430
Opened 11 years ago
Closed 11 years ago
Remove FxAccountsUtils.jsm.
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
5.86 KB,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
FxAccountsUtils.jsm contains a single function that is only used by
FxAccounts.jsm. Let's just move that function into FxAccounts.jsm, avoiding the
creation of a compartment.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8406639 -
Flags: review?(ttaubert)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8406639 [details] [diff] [review]
Remove FxAccountsUtils.jsm.
Review of attachment 8406639 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, I think Mark would be happy to remove the whole stuff anyway but for now removing the extra module should suffice!
Attachment #8406639 -
Flags: review?(ttaubert) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
> Thanks, I think Mark would be happy to remove the whole stuff anyway but for
> now removing the extra module should suffice!
What do you mean by "whole stuff"?
|
|
||
Comment 4•11 years ago
|
||
The public/private API setup that copies properties around. This doesn't really work for FxA and its tests, it would involve a lot of rewriting at this stage.
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
You need to log in
before you can comment on or make changes to this bug.
Description
•