Closed Bug 996430 Opened 10 years ago Closed 10 years ago

Remove FxAccountsUtils.jsm.

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

FxAccountsUtils.jsm contains a single function that is only used by
FxAccounts.jsm. Let's just move that function into FxAccounts.jsm, avoiding the
creation of a compartment.
Attachment #8406639 - Flags: review?(ttaubert)
Blocks: 986323
Comment on attachment 8406639 [details] [diff] [review]
Remove FxAccountsUtils.jsm.

Review of attachment 8406639 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I think Mark would be happy to remove the whole stuff anyway but for now removing the extra module should suffice!
Attachment #8406639 - Flags: review?(ttaubert) → review+
> Thanks, I think Mark would be happy to remove the whole stuff anyway but for
> now removing the extra module should suffice!

What do you mean by "whole stuff"?
The public/private API setup that copies properties around. This doesn't really work for FxA and its tests, it would involve a lot of rewriting at this stage.
https://hg.mozilla.org/mozilla-central/rev/f1cbde906d5d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.