Closed Bug 996444 Opened 10 years ago Closed 10 years ago

[B2G] [RIL] remove gTelephonyList

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
1.4 S6 (25apr)
tracking-b2g backlog

People

(Reporter: hsinyi, Assigned: aknow)

Details

(Whiteboard: [p=1])

Attachments

(1 file, 2 obsolete files)

Since Bug 969218, gTelephonyList is never referenced. We could consider cleaning it up.
Put this bug into backlog.
blocking-b2g: --- → backlog
I am fine for removing it. The drawback is that we could not reference all telephony from gTelephonyList when using gdb debug. However, it is ok for me.
Assignee: nobody → szchen
Attached patch Remove gTelephonyList (obsolete) — Splinter Review
Attachment #8407388 - Flags: review?(htsai)
Whiteboard: [p=1]
Target Milestone: --- → 1.4 S6 (25apr)
Comment on attachment 8407388 [details] [diff] [review]
Remove gTelephonyList

Review of attachment 8407388 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/Telephony.cpp
@@ +31,5 @@
>  using mozilla::dom::telephony::kOutgoingPlaceholderCallIndex;
>  
>  namespace {
>  
>  typedef nsAutoTArray<Telephony*, 2> TelephonyList;

Why keep this?
Attached patch #2 Remove gTelephonyList (obsolete) — Splinter Review
Remove the typedef.
Attachment #8407388 - Attachment is obsolete: true
Attachment #8407388 - Flags: review?(htsai)
Attachment #8409987 - Flags: review?(htsai)
Comment on attachment 8409987 [details] [diff] [review]
#2 Remove gTelephonyList

Review of attachment 8409987 [details] [diff] [review]:
-----------------------------------------------------------------

Good.
Attachment #8409987 - Flags: review?(htsai) → review+
Attachment #8409987 - Attachment is obsolete: true
Attachment #8410145 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/7f19a9a6127e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.