996444 - [B2G] [RIL] remove gTelephonyList

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Since Bug 969218, gTelephonyList is never referenced. We could consider cleaning it up.

Comment 1

[Ken Chang[:kenkai]]

Put this bug into backlog.

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

I am fine for removing it. The drawback is that we could not reference all telephony from gTelephonyList when using gdb debug. However, it is ok for me.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Remove gTelephonyList

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8407388 [details] [diff] [review]
Remove gTelephonyList

Review of attachment 8407388 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/Telephony.cpp
@@ +31,5 @@
>  using mozilla::dom::telephony::kOutgoingPlaceholderCallIndex;
>  
>  namespace {
>  
>  typedef nsAutoTArray<Telephony*, 2> TelephonyList;

Why keep this?

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: #2 Remove gTelephonyList

Remove the typedef.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8409987 [details] [diff] [review]
#2 Remove gTelephonyList

Review of attachment 8409987 [details] [diff] [review]:
-----------------------------------------------------------------

Good.

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Remove gTelephonyList. r=hsinyi

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=db7a2ceec7eb

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7f19a9a6127e

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f19a9a6127e