Closed
Bug 996444
Opened 10 years ago
Closed 10 years ago
[B2G] [RIL] remove gTelephonyList
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(tracking-b2g:backlog)
People
(Reporter: hsinyi, Assigned: aknow)
Details
(Whiteboard: [p=1])
Attachments
(1 file, 2 obsolete files)
1.57 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
Since Bug 969218, gTelephonyList is never referenced. We could consider cleaning it up.
Assignee | ||
Comment 2•10 years ago
|
||
I am fine for removing it. The drawback is that we could not reference all telephony from gTelephonyList when using gdb debug. However, it is ok for me.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → szchen
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8407388 -
Flags: review?(htsai)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=1]
Target Milestone: --- → 1.4 S6 (25apr)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8407388 [details] [diff] [review] Remove gTelephonyList Review of attachment 8407388 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/telephony/Telephony.cpp @@ +31,5 @@ > using mozilla::dom::telephony::kOutgoingPlaceholderCallIndex; > > namespace { > > typedef nsAutoTArray<Telephony*, 2> TelephonyList; Why keep this?
Assignee | ||
Comment 5•10 years ago
|
||
Remove the typedef.
Attachment #8407388 -
Attachment is obsolete: true
Attachment #8407388 -
Flags: review?(htsai)
Attachment #8409987 -
Flags: review?(htsai)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8409987 [details] [diff] [review] #2 Remove gTelephonyList Review of attachment 8409987 [details] [diff] [review]: ----------------------------------------------------------------- Good.
Attachment #8409987 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Attachment #8409987 -
Attachment is obsolete: true
Attachment #8410145 -
Flags: review+
Assignee | ||
Comment 8•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=db7a2ceec7eb
Keywords: checkin-needed
Reporter | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/7f19a9a6127e
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f19a9a6127e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•