996477 - ./mach marionette-webapi ImportError: No module named marionette_transport

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

./mach marionette-webapi

ImportError: No module named marionette_transport

  File "/home/allstars/src/github/mozilla-b2g/B2G_emuJB/gecko/testing/marionette/mach_commands.py", line 88, in run_marionette_webapi
    testtype=testtype, topsrcdir=self.topsrcdir, address=None)
  File "/home/allstars/src/github/mozilla-b2g/B2G_emuJB/gecko/testing/marionette/mach_commands.py", line 30, in run_marionette
    from marionette.runtests import (
  File "/home/allstars/src/github/mozilla-b2g/B2G_emuJB/gecko/testing/marionette/client/marionette/__init__.py", line 5, in <module>
    from gestures import *
  File "/home/allstars/src/github/mozilla-b2g/B2G_emuJB/gecko/testing/marionette/client/marionette/gestures.py", line 5, in <module>
    from marionette import MultiActions, Actions
  File "/home/allstars/src/github/mozilla-b2g/B2G_emuJB/gecko/testing/marionette/client/marionette/marionette.py", line 19, in <module>
    from marionette_transport import MarionetteTransport

This happends after Bug 902711 is landed.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Missing "testing/marionette/transport" in "build/mach_bootstrap.py".

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: bug-996477-no-module-named-marionette_transport.patch

Try all because it touches a fundamental file for mach: https://tbpl.mozilla.org/?tree=Try&rev=662e387ef90f

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8406710 [details] [diff] [review]
bug-996477-no-module-named-marionette_transport.patch

Review of attachment 8406710 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Vicamo, and sorry for the bustage.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: Fix ImportError when running mach marionette-webapi

Actually, that patch was missing a file; I've tested this one and it works.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8406959 [details] [diff] [review]
Fix ImportError when running mach marionette-webapi

Review of attachment 8406959 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have a way to verify that additional change to build/virtualenv_packages.txt and I really don't know what is it for.  Commit log shows glandium or gps may know it better.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8406959 [details] [diff] [review]
Fix ImportError when running mach marionette-webapi

Review of attachment 8406959 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/virtualenv_packages.txt
@@ +1,1 @@
> +marionette_transport.pth:testing/marionette/transport

Are there other things than mach that need the marionette transport module? If not, you shouldn't need this.

Comment 7

[Jonathan Griffin (:jgriffin)]

Yes, Marionette tests invoked from mach need the transport; the marionette-webapi command fails without this.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Yes, Marionette tests invoked from mach need the transport; the
> marionette-webapi command fails without this.

I think Mike meant cases other than marionette-webapi.

Comment 9

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3a457bc88a2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f3a457bc88a2

Comment 11

[Martijn Wargers (dead)]

I get this when trying to run this: python runtests.py --binary=/Users/mwargers/mozilla-central/obj-x86_64-apple-darwin13.3.0/dist/ --type=browser tests/unit-tests.ini
When following the instructions at:
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Marionette/Running_Tests#With_a_local_build

MY MARIONETTE_ENV environment points to: /Users/mwargers/mozilla-central/obj-x86_64-apple-darwin13.3.0/_virtualenv/

Comment 12

[Martijn Wargers (dead)]

Ok, ./mach marionette-test (instead of ./mach marionette-webapi) seems to work, but then I'm wondering why this python runtests.py thing is still documented.

Comment 13

[Jonathan Griffin (:jgriffin)]

The runtests.py path is still documented because not command-line args are supported via mach, and you can't use mach to run tests with a downloaded build and tests.zip.

But, I agree we should add information about mach here.

Comment 14

[Martijn Wargers (dead)]

Ok, I added some short info about mach there.