996494 - Implement nsIFxAccountsUIGlue in desktop

Status: NEW

(Firefox :: Firefox Accounts, enhancement)

Description

[Fernando Jiménez Moreno [:ferjm]]

Consumers of the FxAccounts API shouldn't need to manage account states. In B2G, when a consumer asks for an assertion and there is no logged-in account, we automatically launch the login UI. If the login is successful (and the account used is verified), the consumer gets the assertion.

It would be great to have this same experience in desktop. This way, consumers like the Loop client should need to worry about opening about:accounts or asking the user to do it or even check if there is an existing account. It should only need to call FxAccounts.getAssertion().

We can do it by implementing nsIFxAccountsUIGlue [1] in desktop and moving part of this logic from FxAccountsManager [2] to FxAccounts [3]. We can also make it optional, so the consumer can decide if it wants the platform to trigger the login UI or not.

We can start with the singInFlow [4] only.

[1] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/interfaces/nsIFxAccountsUIGlue.idl
[2] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccountsManager.jsm#412
[3] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/FxAccounts.jsm#409
[4] https://mxr.mozilla.org/mozilla-central/source/services/fxaccounts/interfaces/nsIFxAccountsUIGlue.idl#11

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #0)
> This way,
> consumers like the Loop client should need to worry about opening
> about:accounts

s/should/should NOT/

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Mark, do you think this is worth trying?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

If loop becomes the first FxA desktop consumer that isn't Sync, then yeah, we should do this.

Comment 4

[Matthew N. [:MattN]]

Marco, please remove this from the prioritized backlog as ckarlof tells me there are no current plans to implement this. We are going with bug 1022064 for now instead.

Comment 5

[Marco Mucci [:MarcoM]]

Removed from Iteration 33.3 prioritized backlog.

Comment 6

[Chris Karlof [:ckarlof]]

This doesn't block FxA/Loop integration, as mentioned by :mattN in comment 4.