996510 - gaia-ui-test test case for Bug 906164

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Henry Chang [:hchang]]

We need a gaia-ui-test test case for Bug 906164, which is trying to solve a potential bug that system message may be not delivered to an opening app.

Comment 1

[Henry Chang [:hchang]]

I've written the test case but that test case will have side effect when running on Desktop B2G. The root cause is Bug 996508. I could reproduce the case described in Bug 996508.

Comment 2

[Henry Chang [:hchang]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19021

Comment 3

[Henry Chang [:hchang]]

Comment on attachment 8424563 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19021

Hi Zac, could you please help review this PR? I added a new test case for system message and extract some common utility functions to app.py. But I am wondering why the travis ci test was not run automatically. Is there any way to manually re-trigger it? Or I have to push again? Thanks!

Comment 4

[Zac C (:zac)]

Comment on attachment 8424563 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19021

Robert, can you take care of this? Thanks

Comment 5

[Robert Chira [:RobertC]]

Comment on attachment 8424563 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19021

Comments in the PR

Comment 6

[Henry Chang [:hchang]]

Comment on attachment 8424563 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19021

Updated PR. Could you please review again? Thanks!

Comment 7

[Florin Strugariu [:Bebe]]

Comment on attachment 8424563 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19021

Looks OK 

But it need a rebase

Comment 8

[Henry Chang [:hchang]]

(In reply to Florin Strugariu [:Bebe] from comment #7)
> Comment on attachment 8424563 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/19021
> 
> Looks OK 
> 
> But it need a rebase

Do I have to wait until :zampbell's review or I can update the PR now? Thanks!

Comment 9

[Florin Strugariu [:Bebe]]

you can rebase it now :D If Zac is OK with it he can merge it after the review :D

Comment 10

[Henry Chang [:hchang]]

(In reply to Florin Strugariu [:Bebe] from comment #9)
> you can rebase it now :D If Zac is OK with it he can merge it after the
> review :D

The rebase is done and passed all the test cases! Thanks!

Comment 11

[Zac C (:zac)]

Comment on attachment 8424563 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19021

r-, one nit: we need it added to tbpl-manifest.ini !

Thanks for moving it all into the app object too, it's very nice and neat :)

Comment 12

[Henry Chang [:hchang]]

(In reply to Zac C (:zac) from comment #11)
> Comment on attachment 8424563 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/19021
> 
> r-, one nit: we need it added to tbpl-manifest.ini !
> 
> Thanks for moving it all into the app object too, it's very nice and neat :)

Thanks for your review! I've added it to tpbl-manifest.ini. What else should I do? I was hoping to have a try run with this  custom gaia but found no way to run gaia ui test with custom gaia. Thanks!

Comment 13

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/50b829972c2410dbf90b8368bdd164f0d6e122eb