996569 - Improve performance of FB and other services contacts importation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Gareth Aye [:gaye] (back from PTO)]

It took me a few minutes to fetch ~250 friends on a 50mbps Internet connection. The facebook data we need is not very much at all and this is an important time to start users off on the right foot. Imagine instead of a 50mbps connection I had a 500kbps connection...

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

This was 1.4 on a buri with gaia@c8f916 ftr

Comment 2

[Jose Manuel Cantera]

slow is a relative concept. you need to provide the environment and the measurements but in general importing FB contacts has been pretty fast in general. 

Of course, there can be regressions but as that code has not changed recently that could be performance regressions from Gecko or whatever.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

I am just a user and should not need to "prove" that sitting around for three minutes while the facebook contact importer ran was an unpleasant experience.

Anyhow, in this case my Internet connection was not the bottleneck. It was either Facebook's people fetching api or the client code. If ~80 contacts/min is acceptable performance in this scenario, then I suggest that allow contacts to be downloaded in the background, let users continue to enjoy their brand new phones, and maybe send a notification once their contacts have finished thinking. Thoughts?

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch related to chunk

Maybe we have to work in more parts but I would like to split into different patches.

This patch maintains the idea based on importing friends by means of chunks (5 items at the same time). But, instead of importing 5 items and once they are imported we continue with next 5 items. We will land 5 items at the beginning and when one of them will be imported, we will try to import another one immediately in order to guarantee that we will have 5 items importing at the same time without waiting for finishing all of them in a chunk. As soon as a friend finishes another one enters

Thanks for the idea Jose

Comment 5

[Jose Manuel Cantera]

Comment on attachment 8412513 [details]
Patch related to chunk

good work thanks!

Comment 6

[Cristian Rodriguez (:crdlc)]

Merged in master patch related to chunk

https://github.com/mozilla-b2g/gaia/commit/08cdbbbf5c35f7002388b920d4fb75570f2ae0d1