Closed
Bug 996569
Opened 11 years ago
Closed 11 years ago
Improve performance of FB and other services contacts importation
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: gaye, Assigned: crdlc)
Details
(Keywords: perf, Whiteboard: [c=progress p= s=2014.05.09.t u=])
Attachments
(1 file)
It took me a few minutes to fetch ~250 friends on a 50mbps Internet connection. The facebook data we need is not very much at all and this is an important time to start users off on the right foot. Imagine instead of a 50mbps connection I had a 500kbps connection...
Reporter | ||
Comment 1•11 years ago
|
||
This was 1.4 on a buri with gaia@c8f916 ftr
Updated•11 years ago
|
Keywords: perf
OS: Linux → Gonk (Firefox OS)
Priority: -- → P1
Hardware: x86 → ARM
Whiteboard: [c=progress p= s= u=]
Comment 2•11 years ago
|
||
slow is a relative concept. you need to provide the environment and the measurements but in general importing FB contacts has been pretty fast in general.
Of course, there can be regressions but as that code has not changed recently that could be performance regressions from Gecko or whatever.
Reporter | ||
Comment 3•11 years ago
|
||
I am just a user and should not need to "prove" that sitting around for three minutes while the facebook contact importer ran was an unpleasant experience.
Anyhow, in this case my Internet connection was not the bottleneck. It was either Facebook's people fetching api or the client code. If ~80 contacts/min is acceptable performance in this scenario, then I suggest that allow contacts to be downloaded in the background, let users continue to enjoy their brand new phones, and maybe send a notification once their contacts have finished thinking. Thoughts?
Assignee | ||
Comment 4•11 years ago
|
||
Maybe we have to work in more parts but I would like to split into different patches.
This patch maintains the idea based on importing friends by means of chunks (5 items at the same time). But, instead of importing 5 items and once they are imported we continue with next 5 items. We will land 5 items at the beginning and when one of them will be imported, we will try to import another one immediately in order to guarantee that we will have 5 items importing at the same time without waiting for finishing all of them in a chunk. As soon as a friend finishes another one enters
Thanks for the idea Jose
Attachment #8412513 -
Flags: review?(jmcf)
Updated•11 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Updated•11 years ago
|
Summary: Importing FB contacts is soooooooooooooooooooo slow → Improve performance of FB and other services contacts importation
Comment 5•11 years ago
|
||
Comment on attachment 8412513 [details]
Patch related to chunk
good work thanks!
Attachment #8412513 -
Flags: review?(jmcf) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Merged in master patch related to chunk
https://github.com/mozilla-b2g/gaia/commit/08cdbbbf5c35f7002388b920d4fb75570f2ae0d1
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
status-b2g-v2.0:
--- → fixed
Target Milestone: --- → 2.0 S1 (9may)
Updated•11 years ago
|
Whiteboard: [c=progress p= s= u=] → [c=progress p= s=2014.05.09.t u=]
You need to log in
before you can comment on or make changes to this bug.
Description
•