996633 - {{ssid}} is displayed instead of the Wireless network name in settings app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Viorela Ioia [:viorela]]

Network name is not displayed in Settings app, wifi section, after connecting to it.

Gaia      553da99ab09b6b894d9f95bb06b16b6e1ddbf0a1
Gecko     https://hg.mozilla.org/mozilla-central/rev/5b6e82e7bbbf
BuildID   20140415040201
Version   31.0a1
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013

# STR:
1. Flash your phone with the latest v1.5 build
2. Open Settings app
3. Connect to a network

# Expected results: 
Connected to + the name of the network is displayed in the Wi-Fi section

# Actual results:
Connected to + {{ssid}} is displayed in the Wi-Fi section

Comment 1

[Florin Strugariu [:Bebe]]

We can reproduce this issue Manually and with Automation

Comment 2

[Jason Smith [:jsmith]]

We need a screenshot & indication if this reproduces on 1.4.

Comment 3

[Marcia Knous [:marcia]]

Attachment: 2014-04-15-10-54-09.png

Adding the screenshot on Master. Checking 1.4 now.

Comment 4

[Marcia Knous [:marcia]]

This issue doesn't reproduce using the latest Buri 1.4 build:

Gaia   c8f916c8569f6ee652237fd10ac925e08cd3d9bc
SourceStamp f14047fa8d63
BuildID 20140415000202
Version 30.0a2

Comment 5

[bhavana bajaj [:bajaj]]

Tim any thoughts here, any settings related change that may have caused this ? surprising, I saw a similar issue of not displaying the contact name in https://bugzilla.mozilla.org/show_bug.cgi?id=994417. Not sure if they are related but wanted to point it out as atleast it looked like a similar issue on the frontend side, for an end user.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Yeah, they probably related.

Let's get a regression window first and bisecting can follow.

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Dimi, can you help to check if this is related to webidl change ?

Comment 8

[Dimi Lee [:dimi]]

(In reply to Vincent Chang[:vchang] from comment #7)
> Dimi, can you help to check if this is related to webidl change ?

Yes, this is related to webidl change. The root cause is that after changing IDL to WebIDL, network object cannot use JSON.stringify. So there will be some problem when GAIA try to translate the ssid
from network object.
I'll provide patch to fix it

Comment 9

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/gaia

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8407389 [details] [review]
pull request to mozilla-b2g/gaia

Thanks for the patch, dimi. Please check my comment in github.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8407389 [details] [review]
pull request to mozilla-b2g/gaia

r=me, thanks! I'll merge the patch when travis becomes green.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

master :f585c608218e3b6dd3808d69e31ece164e4bda57

Comment 14

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
1.5
Gecko 404219c
Gaia 2b8464d