Closed
Bug 996645
Opened 11 years ago
Closed 11 years ago
Data Connection switch is not waiting for the Connection to be "active" before switching to the the on state
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Bebe, Unassigned)
Details
Attachments
(1 file)
Description:
In the Settings app go to the Cellular&Data menu. Tap on the "Data Connection" switch.
It changes it's state immediately now waiting in the disabled out state for the connection to be avalable
Environment:
Gaia 553da99ab09b6b894d9f95bb06b16b6e1ddbf0a1
Gecko https://hg.mozilla.org/mozilla-central/rev/5b6e82e7bbbf
BuildID 20140415040201
Version 31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013
Reproducible manually: YES
STR:
1. Open the Settings => Cellular&Data
2. tap on the Data connection switch
Expected:
2. The switch should be disabled while the connection is established and then it should change to active(blue) state
Actual:
2. The transition is done instantly the disabled state is not noticed.
The connection becomes active after a few sec
We saw this issue also in the last build:
Gaia f3abbd2d0a60f1a1618db93f8b1957cae6de379c
Gecko https://hg.mozilla.org/mozilla-central/rev/215080b813a7
BuildID 20140414040203
Version 31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013
Comment 2•11 years ago
|
||
Video link is here:
https://www.dropbox.com/s/01mnjxlqjpx9dba/VID_20140415_155117.mp4
If I understand it correctly, during the transition, the switch should be disabled until the transition is complete. for example, the 'E' logo on top becomes active when the data connection transition is complete
Reporter | ||
Comment 3•11 years ago
|
||
npark That is correct.
Something changed and that's not happening any more. Our tests are failing because of that issue.
Reporter | ||
Updated•11 years ago
|
Summary: Data Connection switch is now waiting for the Connection to be "active" before switching to the the on state → Data Connection switch is not waiting for the Connection to be "active" before switching to the the on state
Comment 4•11 years ago
|
||
Removing qawanted tag due to the associated request being fulfilled in comment 2.
Keywords: qawanted
Comment 5•11 years ago
|
||
UX - Can you comment here to what should be the right behavior here?
Flags: needinfo?(firefoxos-ux-bugzilla)
Comment 6•11 years ago
|
||
Flagging Omega on Settings.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(ofeng)
Comment 7•11 years ago
|
||
Actually the current implementation is perfect which doesn't need user to wait. We shouldn't do any changes here unless there are any side effects.
Flags: needinfo?(ofeng)
Reporter | ||
Comment 8•11 years ago
|
||
Thanks Omega for the update
We will modify the test and UnXfail the test.
Can someone from the team update the test to wait for the Cell data connection to be available before going to the next step
And Unxfail the test
Component: Gaia::Settings → Gaia::UI Tests
Priority: -- → P1
Reporter | ||
Comment 9•11 years ago
|
||
Attachment #8410977 -
Flags: review?(zcampbell)
Comment 10•11 years ago
|
||
Comment on attachment 8410977 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18579/files
r-, let's remove the redundant step.
Attachment #8410977 -
Flags: review?(zcampbell) → review-
Reporter | ||
Updated•11 years ago
|
Attachment #8410977 -
Flags: review- → review?(zcampbell)
Comment 11•11 years ago
|
||
Comment on attachment 8410977 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18579/files
r+
Attachment #8410977 -
Flags: review?(zcampbell) → review+
Comment 12•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•