996645 - Data Connection switch is not waiting for the Connection to be "active" before switching to the the on state

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Florin Strugariu [:Bebe]]

Description:

In the Settings app go to the Cellular&Data menu. Tap on the "Data Connection" switch. 

It changes it's state immediately now waiting in the disabled out state for the connection to be avalable

Environment:
Gaia      553da99ab09b6b894d9f95bb06b16b6e1ddbf0a1
Gecko     https://hg.mozilla.org/mozilla-central/rev/5b6e82e7bbbf
BuildID   20140415040201
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013



Reproducible manually: YES

STR:
1. Open the Settings => Cellular&Data
2. tap on the Data connection switch

Expected:
2. The switch should be disabled while the connection is established and then it should change to active(blue) state

Actual:
2. The transition is done instantly the disabled state is not noticed.
The connection becomes active after a few sec




We saw this issue also in the last build:
Gaia      f3abbd2d0a60f1a1618db93f8b1957cae6de379c
Gecko     https://hg.mozilla.org/mozilla-central/rev/215080b813a7
BuildID   20140414040203
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 1

[Jason Smith [:jsmith]]

We need a video of this.

Comment 2

[No-Jun Park [:njpark]]

Video link is here:

https://www.dropbox.com/s/01mnjxlqjpx9dba/VID_20140415_155117.mp4

If I understand it correctly, during the transition, the switch should be disabled until the transition is complete.  for example, the 'E' logo on top becomes active when the data connection transition is complete

Comment 3

[Florin Strugariu [:Bebe]]

npark That is correct. 
Something changed and that's not happening any more. Our tests are failing because of that issue.

Comment 4

[Chris Kreinbring [:CKreinbring]]

Removing qawanted tag due to the associated request being fulfilled in comment 2.

Comment 5

[Jason Smith [:jsmith]]

UX - Can you comment here to what should be the right behavior here?

Comment 6

[Stephany Wilkes]

Flagging Omega on Settings.

Comment 7

[Omega Feng [:Omega] [:馮於懋]]

Actually the current implementation is perfect which doesn't need user to wait. We shouldn't do any changes here unless there are any side effects.

Comment 8

[Florin Strugariu [:Bebe]]

Thanks Omega for the update

We will modify the test and UnXfail the test.


Can someone from the team update the test to wait for the Cell data connection to be available before going to the next step

And Unxfail the test

Comment 9

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18579/files

Comment 10

[Zac C (:zac)]

Comment on attachment 8410977 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18579/files

r-, let's remove the redundant step.

Comment 11

[Zac C (:zac)]

Comment on attachment 8410977 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18579/files

r+

Comment 12

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/1accf8f221e8415c98f41371a8d149486066d4ef