996677 - Incorrect call DeviceRotationRate() ctor from another one

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Maks Naumov]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

./dom/events/DeviceMotionEvent.h 26 & 63

DeviceRotationRate(double aAlpha, double aBeta, double aGamma)
{
   DeviceRotationRate(nullptr, Nullable<double>(aAlpha), Nullable<double>(aBeta), Nullable<double>(aGamma));
}

...
DeviceAcceleration(double aX, double aY, double aZ)
{
  DeviceAcceleration(nullptr, Nullable<double>(aX), Nullable<double>(aY), Nullable<double>(aZ));
}



Expected results:

Created temp DeviceAcceleration obj and then this obj is deleted.
Possible solutions:
1. add some "init()" method
2. for C++11 call one ctor from another:
DeviceAcceleration(double aX, double aY, double aZ)
 : DeviceAcceleration(nullptr, Nullable<double>(aX), Nullable<double>(aY), Nullable<double>(aZ))
{
}


3.
DeviceAcceleration(double aX, double aY, double aZ)
{
  this->DeviceAcceleration(nullptr, Nullable<double>(aX), Nullable<double>(aY), Nullable<double>(aZ))
}
It is dangerous because "DeviceAcceleration" not base class

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

/me slaps himself

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I think we can just remove those problematic ctors.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Builds at least on linux, and mxr didn't find any use of those ctors.
https://tbpl.mozilla.org/?tree=Try&rev=927fa6349968

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8406994 [details] [diff] [review]
patch

The wreckage of the XPCOM interface...

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c4a02a5c169

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c4a02a5c169