Bug 958584 regressed - accessing the statusbar from a fullscreen app

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: etienne, Assigned: etienne)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
benfrancis
: review+
kgrandon
: feedback+
Details | Review
Assignee

Description

5 years ago
The spec is on the original bug https://bugzilla.mozilla.org/attachment.cgi?id=8359107.

Not sure exactly when it regressed, we also lost the transition of the status bar.

The integration test should probably be updated too since it didn't catch the regression :/
So I did do a quick test of the system app right before the rocketbar/statusbar combining landed, and I can confirm that this did work at revision aa116a9fb271d92ce9de1b27036187ef242ebabd. I tried bisecting this to be sure, but I think the reverts may have screwed that up as I came up with an unrelated changeset =/ I might give it another go at bisecting later this week.
Assignee

Updated

5 years ago
Assignee: nobody → etienne
Assignee

Comment 2

5 years ago
Posted file Gaia PR
Hey Kevin, made sure this was working with and without the rocketbar. Looking good?
Attachment #8416433 - Flags: review?(kgrandon)
Comment on attachment 8416433 [details] [review]
Gaia PR

Code looks good, thank you!
Attachment #8416433 - Flags: review?(kgrandon) → review+
Comment on attachment 8416433 [details] [review]
Gaia PR

This doesn't work too well if you expand the Rocketbar.

STR:
* Build with Rocketbar turned on
* Open Gallery app
* Swipe down from top to show statusbar
* Swipe down on collapsed Rocketbar to expand it

Expected:
* App window shifts down

Actual:
* Rocketbar overlaps content but statusbar doesn't look right

* Scroll photos in gallery

Expected:
* Rocketbar stays expanded (until we implement auto hide after timeout)

Actual:
* Rocketbar gets half stuck off the screen
Assignee

Comment 5

5 years ago
Comment on attachment 8416433 [details] [review]
Gaia PR

Had a deeper look and the rocketbar is broken in all kinds of ways with fullscreen apps.

I don't think it's wise to implement the rocketbar fullscreen story in this bug (a regression fix). *But* we can't let the bug Ben mentioned happen either.

So in this new version of the patch we're not expanding the rocketbar on top of fullscreen apps. I've added the appropriate TODO but let me know if you want me to reference a bug number.
Attachment #8416433 - Flags: review+ → review?(kgrandon)
Comment on attachment 8416433 [details] [review]
Gaia PR

I generally support bringing back the feature as rocketbar caused the regression and this is more important in 2.0. I do think Ben should take a look at this though as he had concerns and this is touching some of the stuff he's worked on.
Attachment #8416433 - Flags: review?(kgrandon)
Attachment #8416433 - Flags: review?(bfrancis)
Attachment #8416433 - Flags: feedback+
Comment on attachment 8416433 [details] [review]
Gaia PR

I don't think this fix will work so well in cases where an app enters full screen some time after launch, but you're right the Rocketbar is broken for fullscreen apps and this seems like a good way to fix the regression without creating new ones.

Please just add a reference to bug 1005248 in the comments.

Thanks very much for fixing this and sorry for the oversight! Nice work adding the test :)
Attachment #8416433 - Flags: review?(bfrancis) → review+
Merged into master https://github.com/mozilla-b2g/gaia/commit/84c00850aae6c9ed1918c5b8743c52333b83a0a2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Oh damn, forgot to wait for adding the comment. Never mind :)
You need to log in before you can comment on or make changes to this bug.