Closed
Bug 996708
Opened 11 years ago
Closed 10 years ago
Set an explicit width/height for images in dynamic panel empty views
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
1.35 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
We may also want to address this as part of bug 985134.
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → margaret.leibovic
|
|
Assignee | |
Comment 1•10 years ago
|
||
Setting P2 hub bugs to block hub v2 EPIC bug (targeting fx31 release). Filter on epic-hub-bugs.
Blocks: 1014030
|
|
Assignee | |
Comment 2•10 years ago
|
||
This is pretty simple, just taking the size of the default image we use (icon_home_empty_firefox). I'll update the docs to recommend developers use this size for their empty images
Attachment #8429677 -
Flags: review?(lucasr.at.mozilla)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Updated here: https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Home.jsm/panels#Empty_view_options
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8429677 [details] [diff] [review] Set an explicit width/height for home_empty_image Review of attachment 8429677 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8429677 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/25bad10a57c4
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/25bad10a57c4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•