Closed Bug 996780 Opened 6 years ago Closed 6 years ago

Eclipse projects only support Android-16 SDK target

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(1 file, 3 obsolete files)

My build uses android-19 and when I imported the Eclipse projects, it said could not find "android-16" target.
This patch uses the basename of ANDROID_SDK (e.g. /foo/sdk/platforms/android-19) as the target.
Attachment #8407046 - Flags: review?(nalexander)
Comment on attachment 8407046 [details] [diff] [review]
Use ANDROID_SDK for Eclipse project target (v1)

Review of attachment 8407046 [details] [diff] [review]:
-----------------------------------------------------------------

See Bug 979438.  You should be able to just use ANDROID_TARGET_SDK in project.properties, like:

target=android-@ANDROID_TARGET_SDK@

(That is, no IDE_* variable should be needed.)  If it works, r=me with that.
Attachment #8407046 - Flags: review?(nalexander) → review-
Didn't work,

> mozbuild.preprocessor.Error: (u'/home/nchen/gecko-dev/python/mozbuild/mozbuild/backend/templates/android_eclipse/project.properties', 12, 'UNDEFINED_VAR', 'ANDROID_TARGET_SDK')

This patch works. I got rid of the default value because if ANDROID_TARGET_SDK doesn't exist we have bigger things to worry about.
Attachment #8407046 - Attachment is obsolete: true
Attachment #8407059 - Flags: review?(nalexander)
Comment on attachment 8407059 [details] [diff] [review]
Use ANDROID_TARGET_SDK for Eclipse project target (v2)

Review of attachment 8407059 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, I remember why this doesn't work.  It's not trivial to get the Mach context from in the build-backend command, so we don't just have the entire config/subst dictionary at hand.

::: python/mozbuild/mozbuild/backend/android_eclipse.py
@@ +237,5 @@
>              filteredResources = self._Element_for_filtered_resources(data.filtered_resources)
>              defines['IDE_PROJECT_FILTERED_RESOURCES'] = pretty_print(filteredResources).strip()
>          else:
>              defines['IDE_PROJECT_FILTERED_RESOURCES'] = ''
> +        defines['IDE_TARGET_SDK'] = self.environment.substs['ANDROID_TARGET_SDK']

gentle preference to not change the name.
Attachment #8407059 - Flags: review?(nalexander) → review+
Thanks!
Attachment #8407059 - Attachment is obsolete: true
Attachment #8407085 - Flags: review+
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/373d7b1c42e0
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/373d7b1c42e0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
You need to log in before you can comment on or make changes to this bug.