996780 - Eclipse projects only support Android-16 SDK target

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

My build uses android-19 and when I imported the Eclipse projects, it said could not find "android-16" target.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use ANDROID_SDK for Eclipse project target (v1)

This patch uses the basename of ANDROID_SDK (e.g. /foo/sdk/platforms/android-19) as the target.

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8407046 [details] [diff] [review]
Use ANDROID_SDK for Eclipse project target (v1)

Review of attachment 8407046 [details] [diff] [review]:
-----------------------------------------------------------------

See Bug 979438.  You should be able to just use ANDROID_TARGET_SDK in project.properties, like:

target=android-@ANDROID_TARGET_SDK@

(That is, no IDE_* variable should be needed.)  If it works, r=me with that.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use ANDROID_TARGET_SDK for Eclipse project target (v2)

Didn't work,

> mozbuild.preprocessor.Error: (u'/home/nchen/gecko-dev/python/mozbuild/mozbuild/backend/templates/android_eclipse/project.properties', 12, 'UNDEFINED_VAR', 'ANDROID_TARGET_SDK')

This patch works. I got rid of the default value because if ANDROID_TARGET_SDK doesn't exist we have bigger things to worry about.

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8407059 [details] [diff] [review]
Use ANDROID_TARGET_SDK for Eclipse project target (v2)

Review of attachment 8407059 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, I remember why this doesn't work.  It's not trivial to get the Mach context from in the build-backend command, so we don't just have the entire config/subst dictionary at hand.

::: python/mozbuild/mozbuild/backend/android_eclipse.py
@@ +237,5 @@
>              filteredResources = self._Element_for_filtered_resources(data.filtered_resources)
>              defines['IDE_PROJECT_FILTERED_RESOURCES'] = pretty_print(filteredResources).strip()
>          else:
>              defines['IDE_PROJECT_FILTERED_RESOURCES'] = ''
> +        defines['IDE_TARGET_SDK'] = self.environment.substs['ANDROID_TARGET_SDK']

gentle preference to not change the name.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use ANDROID_TARGET_SDK for Eclipse project target (v2.1)

Thanks!

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/16fc740d96f5

Comment 7

[Carsten Book [:Tomcat]]

sorry had to backout for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=37909081&tree=Fx-Team

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use ANDROID_TARGET_SDK for Eclipse project target (v2.2)

Trivial change to fix the test.

Try: https://tbpl.mozilla.org/?tree=Try&rev=ff7b469f3c69

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/373d7b1c42e0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/373d7b1c42e0