Closed Bug 996798 Opened 6 years ago Closed 6 years ago

make node/wrappercache flags type a typedef instead of typing uint32_t everywhere

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(2 files)

I have a patch to make the nsINode/nsWrapperCache flags type a typedef rather than typing uint32_t everywhere.

I was thinking I might need this to temporarily bump to 64-bit for bug 996796, at least temporarily until bug 960465 is complete, but I think we have the spare bits that we don't need to.  There are also some issues with bug 960465 that I don't yet know how to solve, so there might be a more substantial gap in time than I originally though between when those two changes land (or it might be that the fix for those issues involves not giving the two bits back).
(For the record, I'm currently 1 bit short for my need for 2 bits for bug 996796.)
(Currently we have 31 bits used:  2 on nsWrapperCache, 22 on nsINode, 4 on Element, and 3 on nsXULElement.)
Don't we have still spare BooleanFlags
Did the patch in bug 8388060 ever land?  If not, we should land it.
Comment on attachment 8407063 [details] [diff] [review]
Add a typedef to make it easier to change the size of nsWrapperCache/nsINode flags

r=me
Attachment #8407063 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/6e62d26d659c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Comment on attachment 8447668 [details] [diff] [review]
patch 2 - Make the ability to change nsWrapperCache::FlagsType more portable

r=me
Attachment #8447668 - Flags: review?(bzbarsky) → review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.