996798 - make node/wrappercache flags type a typedef instead of typing uint32_t everywhere

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I have a patch to make the nsINode/nsWrapperCache flags type a typedef rather than typing uint32_t everywhere.

I was thinking I might need this to temporarily bump to 64-bit for bug 996796, at least temporarily until bug 960465 is complete, but I think we have the spare bits that we don't need to.  There are also some issues with bug 960465 that I don't yet know how to solve, so there might be a more substantial gap in time than I originally though between when those two changes land (or it might be that the fix for those issues involves not giving the two bits back).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add a typedef to make it easier to change the size of nsWrapperCache/nsINode flags

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(For the record, I'm currently 1 bit short for my need for 2 bits for bug 996796.)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Currently we have 31 bits used:  2 on nsWrapperCache, 22 on nsINode, 4 on Element, and 3 on nsXULElement.)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Don't we have still spare BooleanFlags

Comment 5

[Boris Zbarsky [:bzbarsky]]

Did the patch in bug 8388060 ever land?  If not, we should land it.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, I meant bug 981257.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8407063 [details] [diff] [review]
Add a typedef to make it easier to change the size of nsWrapperCache/nsINode flags

r=me

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=fbaab9aa48aa

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e62d26d659c

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6e62d26d659c

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2 - Make the ability to change nsWrapperCache::FlagsType more portable

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8447668 [details] [diff] [review]
patch 2 - Make the ability to change nsWrapperCache::FlagsType more portable

r=me

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83d81f2f0372

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/83d81f2f0372