996823 - mach interferes with ctrl-c when running with gdb

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

Sometimes when using gdb with mach reftest --debugger=gdb I'll get a message like:
mach interrupted by signal or user action. Stopping.

This causes pain.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I guess the solution here is to setup a handler for SIGINT and forward that to gdb?

Comment 2

[Matt Woodrow (:mattwoodrow)]

This is causing pain for me too. 

Ctrl-C causes mach to exit and locks my terminal tab, but doesn't break the debugger or kill it.

Would like a way to workaround this at least so I can debug reftests again.

Comment 3

[Gregory Szorc [:gps]]

You'll have to change each mach command not reacting properly to ctrl-c to swallow KeyboardInterrupt. We may want to consider a per-command option to ignore KeyboardInterrupt, since this is likely a common pattern.

Better yet, whatever the mach command invokes should swallow KeyboardInterrupt.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I use |./mach debug| on Mac. After hitting Ctrl-C, it prints "mach interrupted by signal or user action. Stopping.", and lldb is terminated.

The expect behavior should be sending Ctrl-C to the debugger. Is there any attempt to resolve this issue?

Comment 6

[Matt Woodrow (:mattwoodrow)]

Is this going to be fixed?

EXTRA_TEST_ARGS='--debugger=lldb' make reftest doesn't seem to work any more either.

Comment 7

[(no longer active)]

gps is away.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

1) In my experience, mach debug has negative usefulness because of that. I think it should be plain removed until this is fixed.

2) Why does mach debug have to keep running while GDB is running? Why can't mach debug just exec GDB and be done?

Comment 9

[Mike Hommey [:glandium]]

Attachment: Let mach pass-through subprocesses handle Ctrl-C themselves

Arguably, that should be done for the non-pass_thru case. There's really no reason not
to leave it to subprocesses to decide what they want to do on Ctrl-C, and get the python
code get back on a code path as if the subprocess terminated normally. But I don't feel
like I want to touch mozbase.

Comment 10

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60793d877475

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60793d877475