996831 - Add a ToJSValue overload for nsresult

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This should return a DOMError or exception based on the error code. Useful for non-[Throws] Promises that should be rejected by errors.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add a ToJSValue overload for nsresult, to allow rejecting promises from C++ more easily.

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8407620 [details] [diff] [review]
Add a ToJSValue overload for nsresult, to allow rejecting promises from C++ more easily.

Review of attachment 8407620 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: dom/bindings/ToJSValue.h
@@ +211,5 @@
>    aValue.set(aArgument);
>    return MaybeWrapValue(aCx, aValue);
>  }
>  
> +// Accept nsresult, for use in rejections

Mention that this converts the result into an XPCOM exception object?

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7acce569bd84 with the comment.

Comment 4

[Boris Zbarsky [:bzbarsky]]

And https://hg.mozilla.org/integration/mozilla-inbound/rev/8f98a4c2257f to make gcc happy.

Comment 5

[Boris Zbarsky [:bzbarsky]]

And b2g is _still_ unhappy, since nsresult is uint32_t over there, apparently, so those two signatures are not distinguishable.  :(

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b54654e26cd

Comment 7

[Boris Zbarsky [:bzbarsky]]

I ifdefed out the uint32_t ToJSValue for now.  https://hg.mozilla.org/integration/mozilla-inbound/rev/5d75982d37a5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5d75982d37a5